diff mbox

[PULL,08/10] net: Remove duplicate data from query-rx-filter on multiqueue net devices

Message ID 1445926124-30681-9-git-send-email-jasowang@redhat.com
State New
Headers show

Commit Message

Jason Wang Oct. 27, 2015, 6:08 a.m. UTC 
From: Vladislav Yasevich <vyasevic@redhat.com>

When responding to a query-rx-filter command on a multiqueue
netdev, qemu reports the data for each queue.  The data, however,
is not per-queue, but per device and the same data is reported
multiple times.  This causes confusion and may also cause extra
unnecessary processing when looking at the data.

Commit 638fb14169 (net: Make qmp_query_rx_filter() with name argument
more obvious) partially addresses this issue, by limiting the output
when the name is specified.  However, when the name is not specified,
the issue still persists.

Signed-off-by: Vladislav Yasevich <vyasevic@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
 net/net.c | 6 ++++++
 1 file changed, 6 insertions(+)
diff mbox

Patch

diff --git a/net/net.c b/net/net.c
index 3c68f3f..70a3576 100644
--- a/net/net.c
+++ b/net/net.c
@@ -1227,6 +1227,12 @@  RxFilterInfoList *qmp_query_rx_filter(bool has_name, const char *name,
             continue;
         }
 
+        /* only query information on queue 0 since the info is per nic,
+         * not per queue
+         */
+        if (nc->queue_index != 0)
+            continue;
+
         if (nc->info->query_rx_filter) {
             info = nc->info->query_rx_filter(nc);
             entry = g_malloc0(sizeof(*entry));