From patchwork Fri Oct 2 19:09:25 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Patchwork-Id: 525740 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 1BBC51402F0 for ; Sat, 3 Oct 2015 05:29:40 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=jCTXT7iE; dkim-atps=neutral Received: from localhost ([::1]:34634 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zi61S-0000Sa-3S for incoming@patchwork.ozlabs.org; Fri, 02 Oct 2015 15:29:38 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34073) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zi5j1-0007bs-3k for qemu-devel@nongnu.org; Fri, 02 Oct 2015 15:10:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zi5j0-0007Zx-2y for qemu-devel@nongnu.org; Fri, 02 Oct 2015 15:10:34 -0400 Received: from mail-wi0-x230.google.com ([2a00:1450:400c:c05::230]:36263) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zi5iz-0007Yh-SB for qemu-devel@nongnu.org; Fri, 02 Oct 2015 15:10:34 -0400 Received: by wicgb1 with SMTP id gb1so45860208wic.1 for ; Fri, 02 Oct 2015 12:10:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=JzLe8lpmTJzGAPEhAGgR6qqsHm8NGzGArsFLFazH0JI=; b=jCTXT7iEv8tsZqs3Xko93rMORAixp8/+qRssHo6GkaV/+pnaiXD6UHub06T2T1H9le mbnMiaerSOcmh6lttTv8mIvTQae+R4+E4DRKL1MPlODf1TuLQEogZSAo1yivf5on5Ypx 2nGNx6pxjxNRECctpSXWNHjBcTtQjWx0dzE+90ek53fuvm2/yeq4iGCwEXrs+98gIahs 23kCukYJlCQzr3Zrzz3jLah3+LF6KPOXzKYnkAdVK1tx7V37AnT18twSMs7BSVVtbiNe bzB8nOeDKuiEe9ocrBwN4iOWTI/7qqjuDYWIHJKL2qXfAtHhUQiD7G2CkzYWcBzmJLnB 9iig== X-Received: by 10.180.93.131 with SMTP id cu3mr476937wib.8.1443813033284; Fri, 02 Oct 2015 12:10:33 -0700 (PDT) Received: from localhost (bne75-h02-31-39-163-232.dsl.sta.abo.bbox.fr. [31.39.163.232]) by smtp.gmail.com with ESMTPSA id fx2sm367979wib.24.2015.10.02.12.10.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 02 Oct 2015 12:10:32 -0700 (PDT) From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Date: Fri, 2 Oct 2015 21:09:25 +0200 Message-Id: <1443812991-17356-23-git-send-email-marcandre.lureau@redhat.com> X-Mailer: git-send-email 2.4.3 In-Reply-To: <1443812991-17356-1-git-send-email-marcandre.lureau@redhat.com> References: <1443812991-17356-1-git-send-email-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c05::230 Cc: drjones@redhat.com, claudio.fontana@huawei.com, stefanha@redhat.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , pbonzini@redhat.com, cam@cs.ualberta.ca Subject: [Qemu-devel] [PATCH v5 22/48] ivshmem: use common is_power_of_2() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Marc-André Lureau The common version correctly checks for 0 value case. Signed-off-by: Marc-André Lureau Reviewed-by: Claudio Fontana --- hw/misc/ivshmem.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index fbb6f40..e678b18 100644 --- a/hw/misc/ivshmem.c +++ b/hw/misc/ivshmem.c @@ -117,10 +117,6 @@ static inline uint32_t ivshmem_has_feature(IVShmemState *ivs, return (ivs->features & (1 << feature)); } -static inline bool is_power_of_two(uint64_t x) { - return (x & (x - 1)) == 0; -} - /* accessing registers - based on rtl8139 */ static void ivshmem_update_irq(IVShmemState *s) { @@ -632,7 +628,7 @@ static uint64_t ivshmem_get_size(IVShmemState * s, Error **errp) { } /* BARs must be a power of 2 */ - if (!is_power_of_two(value)) { + if (!is_power_of_2(value)) { error_setg(errp, "size must be power of 2"); return 0; }