From patchwork Tue Sep 29 16:34:36 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Patchwork-Id: 524559 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 90EF11402B6 for ; Thu, 1 Oct 2015 06:40:03 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=Z2CraWp0; dkim-atps=neutral Received: from localhost ([::1]:32888 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZhOAT-0003t1-Iu for incoming@patchwork.ozlabs.org; Wed, 30 Sep 2015 16:40:01 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51040) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zgxs5-0002Cz-OE for qemu-devel@nongnu.org; Tue, 29 Sep 2015 12:35:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zgxs4-0003rB-W8 for qemu-devel@nongnu.org; Tue, 29 Sep 2015 12:35:17 -0400 Received: from mail-qg0-x22d.google.com ([2607:f8b0:400d:c04::22d]:35205) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zgxs4-0003r7-Su for qemu-devel@nongnu.org; Tue, 29 Sep 2015 12:35:16 -0400 Received: by qgt47 with SMTP id 47so11014046qgt.2 for ; Tue, 29 Sep 2015 09:35:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=jpx9CQ8eCg7DLZAy+uSbEakPPKm1cR19pk6VLykJAI0=; b=Z2CraWp0LPaXO3d0UNLVDsljlmKLHKWDsSrojUuUxfj4ORuWqAVMxXW9IpPhWD6XUJ FkuixYmDUw7LVufRF1rsFgzoScQi4bC3bvGAjUUNXiRcfrod15VP5bwdRAnacWktN4rA 3tvUId5mGS/2MA7RjbVA1eCtXBH9Bv4YSIoUlW271iUjmaFvxLqsC9uO1FmoF57JXqTe GPhRYBQuWcg0gv11py8kAxmBPkzn9wS+j3BoBxrjESaUNVGGGDB2EdeQ+9U6msc5ryQU 7AI9hW/5Ildz6RtTSP2MXw20MTxohxND3gUlrG2vCOYYgL1bSZ//mshyoZBtSRtntVeR r2Pw== X-Received: by 10.140.217.146 with SMTP id n140mr31955905qhb.27.1443544516675; Tue, 29 Sep 2015 09:35:16 -0700 (PDT) Received: from localhost (bne75-h02-31-39-163-232.dsl.sta.abo.bbox.fr. [31.39.163.232]) by smtp.gmail.com with ESMTPSA id a88sm9610422qge.18.2015.09.29.09.35.15 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Sep 2015 09:35:16 -0700 (PDT) From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Date: Tue, 29 Sep 2015 18:34:36 +0200 Message-Id: <1443544494-28737-7-git-send-email-marcandre.lureau@redhat.com> X-Mailer: git-send-email 2.4.3 In-Reply-To: <1443544494-28737-1-git-send-email-marcandre.lureau@redhat.com> References: <1443544494-28737-1-git-send-email-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400d:c04::22d Cc: haifeng.lin@huawei.com, mst@redhat.com, thibaut.collet@6wind.com, jasowang@redhat.com, pbonzini@redhat.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Subject: [Qemu-devel] [PATCH v6 06/24] memfd: add fallback for memfd X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Marc-André Lureau Add an open/unlink/mmap fallback for system that do not support memfd. This patch may require additional SELinux policies to work for enforced systems, but should gracefully fail nonetheless. Signed-off-by: Marc-André Lureau --- util/memfd.c | 22 ++++++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/util/memfd.c b/util/memfd.c index 3168902..970b5b0 100644 --- a/util/memfd.c +++ b/util/memfd.c @@ -84,8 +84,26 @@ void *qemu_memfd_alloc(const char *name, size_t size, unsigned int seals, return NULL; } } else { - perror("memfd"); - return NULL; + const char *tmpdir = getenv("TMPDIR"); + gchar *fname; + + tmpdir = tmpdir ? tmpdir : "/tmp"; + + fname = g_strdup_printf("%s/memfd-XXXXXX", tmpdir); + mfd = mkstemp(fname); + unlink(fname); + g_free(fname); + + if (mfd == -1) { + perror("mkstemp"); + return NULL; + } + + if (ftruncate(mfd, size) == -1) { + perror("ftruncate"); + close(mfd); + return NULL; + } } ptr = mmap(0, size, PROT_READ | PROT_WRITE, MAP_SHARED, mfd, 0);