From patchwork Thu Sep 24 11:37:12 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Patchwork-Id: 522241 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4A7C514029C for ; Thu, 24 Sep 2015 21:43:11 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=U7Xk+4r8; dkim-atps=neutral Received: from localhost ([::1]:57992 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zf4vd-0007CK-3I for incoming@patchwork.ozlabs.org; Thu, 24 Sep 2015 07:43:09 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59048) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zf4qy-00077B-3u for qemu-devel@nongnu.org; Thu, 24 Sep 2015 07:38:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zf4qx-0006ac-Ba for qemu-devel@nongnu.org; Thu, 24 Sep 2015 07:38:20 -0400 Received: from mail-qg0-x230.google.com ([2607:f8b0:400d:c04::230]:36084) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zf4qx-0006aO-5H for qemu-devel@nongnu.org; Thu, 24 Sep 2015 07:38:19 -0400 Received: by qgx61 with SMTP id 61so41382551qgx.3 for ; Thu, 24 Sep 2015 04:38:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=23aOuEovyKEifws5DHSAxYsf/P5T91gHFtERBnQJYHg=; b=U7Xk+4r81KrLDW6OWtWIu44bSiQXiBmDYRwZZGXicJhL2SNaSRbvq967axHrWuSTzf d+hdTRXxGltnDwMUj+y5VohZMdW+KSsaL5rbi9fbAeYpYDFMMkBasjGXovoA3NFQCpBT jtV+i6h6kcZM80s+BmtUnPyvAFmKbOluZtdvbvw2XUpHSOGsLHComCMeoJ61lnklXLYM m+xl7sxvPJpYs7WgUkoWXnUoDMngd/LYa1+M6Is16xL3hSJyfoAagSeY76MCahSkRotC sSelVflGzjwoxo4QNNKeqxNoakeapO281CzzxwNpEgafoI48KapDFnEltodyIPRRv+sI zbww== X-Received: by 10.140.231.76 with SMTP id b73mr46199674qhc.87.1443094698783; Thu, 24 Sep 2015 04:38:18 -0700 (PDT) Received: from localhost (bne75-h02-31-39-163-232.dsl.sta.abo.bbox.fr. [31.39.163.232]) by smtp.gmail.com with ESMTPSA id p72sm4281998qha.31.2015.09.24.04.38.17 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Sep 2015 04:38:18 -0700 (PDT) From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Date: Thu, 24 Sep 2015 13:37:12 +0200 Message-Id: <1443094669-4144-11-git-send-email-marcandre.lureau@redhat.com> X-Mailer: git-send-email 2.4.3 In-Reply-To: <1443094669-4144-1-git-send-email-marcandre.lureau@redhat.com> References: <1443094669-4144-1-git-send-email-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400d:c04::230 Cc: drjones@redhat.com, claudio.fontana@huawei.com, stefanha@redhat.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , pbonzini@redhat.com, cam@cs.ualberta.ca Subject: [Qemu-devel] [PATCH v4 10/47] ivshmem: remove last exit(1) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Marc-André Lureau Failing to create a chardev shouldn't be fatal. Signed-off-by: Marc-André Lureau Reviewed-by: Claudio Fontana --- hw/misc/ivshmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index 62547c0..e7224b9 100644 --- a/hw/misc/ivshmem.c +++ b/hw/misc/ivshmem.c @@ -299,7 +299,7 @@ static CharDriverState* create_eventfd_chr_device(void * opaque, EventNotifier * if (chr == NULL) { error_report("creating eventfd for eventfd %d failed", eventfd); - exit(1); + return NULL; } qemu_chr_fe_claim_no_fail(chr);