| Message ID | 1442592388-13840-1-git-send-email-pbutsykin@virtuozzo.com |
|---|---|
| State | New |
| Headers | show |
On 09/18/2015 10:06 AM, Pavel Butsykin wrote: > The hmp command "info pci" accidentally lost when moving from monitor.c > > Signed-off-by: Pavel Butsykin <pbutsykin@virtuozzo.com> > --- > hmp-commands-info.hx | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) Paolo's variant has a better commit message: https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg04893.html
On 18.09.2015 19:26, Eric Blake wrote: > On 09/18/2015 10:06 AM, Pavel Butsykin wrote: >> The hmp command "info pci" accidentally lost when moving from monitor.c >> >> Signed-off-by: Pavel Butsykin <pbutsykin@virtuozzo.com> >> --- >> hmp-commands-info.hx | 14 ++++++++++++++ >> 1 file changed, 14 insertions(+) > Paolo's variant has a better commit message: > https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg04893.html > Ok. I just had to respond to the situation) (Because the notification about the patch didn't come to me..)
Pavel Butsykin <pbutsykin@odin.com> writes: > On 18.09.2015 19:26, Eric Blake wrote: >> On 09/18/2015 10:06 AM, Pavel Butsykin wrote: >>> The hmp command "info pci" accidentally lost when moving from monitor.c >>> >>> Signed-off-by: Pavel Butsykin <pbutsykin@virtuozzo.com> >>> --- >>> hmp-commands-info.hx | 14 ++++++++++++++ >>> 1 file changed, 14 insertions(+) >> Paolo's variant has a better commit message: >> https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg04893.html >> > Ok. I just had to respond to the situation) Appreciated! It's much better to have two fixes for a regression quickly than one late :) > (Because the notification about the patch didn't come to me..)
On 21/09/2015 07:58, Markus Armbruster wrote: > Pavel Butsykin <pbutsykin@odin.com> writes: > >> On 18.09.2015 19:26, Eric Blake wrote: >>> On 09/18/2015 10:06 AM, Pavel Butsykin wrote: >>>> The hmp command "info pci" accidentally lost when moving from monitor.c >>>> >>>> Signed-off-by: Pavel Butsykin <pbutsykin@virtuozzo.com> >>>> --- >>>> hmp-commands-info.hx | 14 ++++++++++++++ >>>> 1 file changed, 14 insertions(+) >>> Paolo's variant has a better commit message: >>> https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg04893.html >>> >> Ok. I just had to respond to the situation) > > Appreciated! It's much better to have two fixes for a regression > quickly than one late :) Are you pulling one of the two? Paolo
Paolo Bonzini <pbonzini@redhat.com> writes: > On 21/09/2015 07:58, Markus Armbruster wrote: >> Pavel Butsykin <pbutsykin@odin.com> writes: >> >>> On 18.09.2015 19:26, Eric Blake wrote: >>>> On 09/18/2015 10:06 AM, Pavel Butsykin wrote: >>>>> The hmp command "info pci" accidentally lost when moving from monitor.c >>>>> >>>>> Signed-off-by: Pavel Butsykin <pbutsykin@virtuozzo.com> >>>>> --- >>>>> hmp-commands-info.hx | 14 ++++++++++++++ >>>>> 1 file changed, 14 insertions(+) >>>> Paolo's variant has a better commit message: >>>> https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg04893.html >>>> >>> Ok. I just had to respond to the situation) >> >> Appreciated! It's much better to have two fixes for a regression >> quickly than one late :) > > Are you pulling one of the two? Can do. I'll reply to the one I apply to my monitor-next branch.
diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx index 9f5a158..a311b46 100644 --- a/hmp-commands-info.hx +++ b/hmp-commands-info.hx @@ -183,6 +183,20 @@ STEXI Show i8259 (PIC) state. ETEXI + { + .name = "pci", + .args_type = "", + .params = "", + .help = "show PCI info", + .mhandler.cmd = hmp_info_pci, + }, + +STEXI +@item info pci +@findex pci +show emulated PCI device info +ETEXI + #if defined(TARGET_I386) || defined(TARGET_SH4) || defined(TARGET_SPARC) || \ defined(TARGET_PPC) || defined(TARGET_XTENSA) {
The hmp command "info pci" accidentally lost when moving from monitor.c Signed-off-by: Pavel Butsykin <pbutsykin@virtuozzo.com> --- hmp-commands-info.hx | 14 ++++++++++++++ 1 file changed, 14 insertions(+)