| Message ID | 1441471439-6157-2-git-send-email-vsementsov@virtuozzo.com |
|---|---|
| State | New |
| Headers | show |
On 09/05/2015 10:43 AM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> > --- The commit message summary mentions a one-line "what" (good), but is lacking a body that says "why" (that is, what was broken that needed fixing?) > block.c | 2 +- > include/block/block.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > It looks like all the patch does is make the signature const-correct, since querying the granularity does not modify the bitmap. So the commit message should say that. With an improved commit message, Reviewed-by: Eric Blake <eblake@redhat.com>
On 09/05/2015 12:43 PM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> > --- > block.c | 2 +- > include/block/block.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/block.c b/block.c > index 4f7fc0d..6d14f5b 100644 > --- a/block.c > +++ b/block.c > @@ -3591,7 +3591,7 @@ uint32_t bdrv_get_default_bitmap_granularity(BlockDriverState *bs) > return granularity; > } > > -uint32_t bdrv_dirty_bitmap_granularity(BdrvDirtyBitmap *bitmap) > +uint32_t bdrv_dirty_bitmap_granularity(const BdrvDirtyBitmap *bitmap) > { > return BDRV_SECTOR_SIZE << hbitmap_granularity(bitmap->bitmap); > } > diff --git a/include/block/block.h b/include/block/block.h > index edc1510..fb7d410 100644 > --- a/include/block/block.h > +++ b/include/block/block.h > @@ -495,7 +495,7 @@ void bdrv_disable_dirty_bitmap(BdrvDirtyBitmap *bitmap); > void bdrv_enable_dirty_bitmap(BdrvDirtyBitmap *bitmap); > BlockDirtyInfoList *bdrv_query_dirty_bitmaps(BlockDriverState *bs); > uint32_t bdrv_get_default_bitmap_granularity(BlockDriverState *bs); > -uint32_t bdrv_dirty_bitmap_granularity(BdrvDirtyBitmap *bitmap); > +uint32_t bdrv_dirty_bitmap_granularity(const BdrvDirtyBitmap *bitmap); > bool bdrv_dirty_bitmap_enabled(BdrvDirtyBitmap *bitmap); > bool bdrv_dirty_bitmap_frozen(BdrvDirtyBitmap *bitmap); > DirtyBitmapStatus bdrv_dirty_bitmap_status(BdrvDirtyBitmap *bitmap); > As with Eric's review, with a commit message added: Reviewed-by: John Snow <jsnow@redhat.com>
diff --git a/block.c b/block.c index 4f7fc0d..6d14f5b 100644 --- a/block.c +++ b/block.c @@ -3591,7 +3591,7 @@ uint32_t bdrv_get_default_bitmap_granularity(BlockDriverState *bs) return granularity; } -uint32_t bdrv_dirty_bitmap_granularity(BdrvDirtyBitmap *bitmap) +uint32_t bdrv_dirty_bitmap_granularity(const BdrvDirtyBitmap *bitmap) { return BDRV_SECTOR_SIZE << hbitmap_granularity(bitmap->bitmap); } diff --git a/include/block/block.h b/include/block/block.h index edc1510..fb7d410 100644 --- a/include/block/block.h +++ b/include/block/block.h @@ -495,7 +495,7 @@ void bdrv_disable_dirty_bitmap(BdrvDirtyBitmap *bitmap); void bdrv_enable_dirty_bitmap(BdrvDirtyBitmap *bitmap); BlockDirtyInfoList *bdrv_query_dirty_bitmaps(BlockDriverState *bs); uint32_t bdrv_get_default_bitmap_granularity(BlockDriverState *bs); -uint32_t bdrv_dirty_bitmap_granularity(BdrvDirtyBitmap *bitmap); +uint32_t bdrv_dirty_bitmap_granularity(const BdrvDirtyBitmap *bitmap); bool bdrv_dirty_bitmap_enabled(BdrvDirtyBitmap *bitmap); bool bdrv_dirty_bitmap_frozen(BdrvDirtyBitmap *bitmap); DirtyBitmapStatus bdrv_dirty_bitmap_status(BdrvDirtyBitmap *bitmap);
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> --- block.c | 2 +- include/block/block.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)