From patchwork Thu Sep 3 01:31:20 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 513768 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 538691400A0 for ; Thu, 3 Sep 2015 11:47:19 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=uxyY2F33; dkim-atps=neutral Received: from localhost ([::1]:43352 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXJcS-0006BI-UG for incoming@patchwork.ozlabs.org; Wed, 02 Sep 2015 21:47:16 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48211) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXJNa-0006Ju-6I for qemu-devel@nongnu.org; Wed, 02 Sep 2015 21:31:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZXJNZ-0002Qb-50 for qemu-devel@nongnu.org; Wed, 02 Sep 2015 21:31:54 -0400 Received: from mail-pa0-x22b.google.com ([2607:f8b0:400e:c03::22b]:33170) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXJNY-0002Pu-I4 for qemu-devel@nongnu.org; Wed, 02 Sep 2015 21:31:53 -0400 Received: by pacex6 with SMTP id ex6so23754486pac.0 for ; Wed, 02 Sep 2015 18:31:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=BVS7eH3M4PqYXyr8IvoaNV4UVCmb4NIlqqukdjABunQ=; b=uxyY2F33gERqNmHHAn4IXuRqYBOl592SYLvwpVr3fr/I1kEFYF+3WhUSZHOKQHplK/ 4A9cHnuzG/VOcvpJahBu0MqYiJhrqje5M+ndZnd+wdIBNyp+EWcB6gn9Syp4NNCfNIW9 VLb+0slHrOQ8PCmImw1iXVERmQFdmctUXOKVge2DtHo8SfPym7df33zo7mHbYQn0InUT 8zcPFrj1l3XIDsCalBAMDL7K4g0849Gegfyem7daulxMWc5y3pNp4tkEPi2YEGWxQGaD UOPe3tTgp4lp3GBvOy08/+2/azh5NR+neLw1tvkVU8fD/uiVqhbilvWtrqf4J1sTSXSi heQw== X-Received: by 10.66.254.65 with SMTP id ag1mr60436046pad.134.1441243911952; Wed, 02 Sep 2015 18:31:51 -0700 (PDT) Received: from bigtime.twiddle.net (50-194-63-110-static.hfc.comcastbusiness.net. [50.194.63.110]) by smtp.gmail.com with ESMTPSA id kz8sm23209851pab.6.2015.09.02.18.31.51 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 02 Sep 2015 18:31:51 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Wed, 2 Sep 2015 18:31:20 -0700 Message-Id: <1441243885-7495-29-git-send-email-rth@twiddle.net> X-Mailer: git-send-email 2.4.3 In-Reply-To: <1441243885-7495-1-git-send-email-rth@twiddle.net> References: <1441243885-7495-1-git-send-email-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400e:c03::22b Cc: peter.maydell@linaro.org Subject: [Qemu-devel] [PATCH v15 28/33] target-tilegx: Handle v1cmpeq, v1cmpne X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-tilegx/translate.c | 51 +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 51 insertions(+) diff --git a/target-tilegx/translate.c b/target-tilegx/translate.c index 78b87bf..609592a 100644 --- a/target-tilegx/translate.c +++ b/target-tilegx/translate.c @@ -93,6 +93,8 @@ typedef struct { #define OE_IM(E,XY) OE(IMM8_OPCODE_##XY, E##_IMM8_OPCODE_##XY, XY) #define OE_SH(E,XY) OE(SHIFT_OPCODE_##XY, E##_SHIFT_OPCODE_##XY, XY) +#define V1_IMM(X) (((X) & 0xff) * 0x0101010101010101ull) + static void gen_exception(DisasContext *dc, TileExcp num) { @@ -245,6 +247,41 @@ static void gen_mul_half(TCGv tdest, TCGv tsrca, TCGv tsrcb, tcg_temp_free(t); } +/* Equality comparison with zero can be done quickly and efficiently. */ +static void gen_v1cmpeq0(TCGv v) +{ + TCGv m = tcg_const_tl(V1_IMM(0x7f)); + TCGv c = tcg_temp_new(); + + /* ~(((v & m) + m) | m | v). Sets the msb for each byte == 0. */ + tcg_gen_and_tl(c, v, m); + tcg_gen_add_tl(c, c, m); + tcg_gen_or_tl(c, c, m); + tcg_gen_nor_tl(c, c, v); + tcg_temp_free(m); + + /* Shift the msb down to form the lsb boolean result. */ + tcg_gen_shri_tl(v, c, 7); + tcg_temp_free(c); +} + +static void gen_v1cmpne0(TCGv v) +{ + TCGv m = tcg_const_tl(V1_IMM(0x7f)); + TCGv c = tcg_temp_new(); + + /* (((v & m) + m) | v) & ~m. Sets the msb for each byte != 0. */ + tcg_gen_and_tl(c, v, m); + tcg_gen_add_tl(c, c, m); + tcg_gen_or_tl(c, c, v); + tcg_gen_andc_tl(c, c, m); + tcg_temp_free(m); + + /* Shift the msb down to form the lsb boolean result. */ + tcg_gen_shri_tl(v, c, 7); + tcg_temp_free(c); +} + static TileExcp gen_st_opcode(DisasContext *dc, unsigned dest, unsigned srca, unsigned srcb, TCGMemOp memop, const char *name) { @@ -915,8 +952,13 @@ static TileExcp gen_rrr_opcode(DisasContext *dc, unsigned opext, case OE_RRR(V1ADD, 0, X1): case OE_RRR(V1ADIFFU, 0, X0): case OE_RRR(V1AVGU, 0, X0): + return TILEGX_EXCP_OPCODE_UNIMPLEMENTED; case OE_RRR(V1CMPEQ, 0, X0): case OE_RRR(V1CMPEQ, 0, X1): + tcg_gen_xor_tl(tdest, tsrca, tsrcb); + gen_v1cmpeq0(tdest); + mnemonic = "v1cmpeq"; + break; case OE_RRR(V1CMPLES, 0, X0): case OE_RRR(V1CMPLES, 0, X1): case OE_RRR(V1CMPLEU, 0, X0): @@ -925,8 +967,13 @@ static TileExcp gen_rrr_opcode(DisasContext *dc, unsigned opext, case OE_RRR(V1CMPLTS, 0, X1): case OE_RRR(V1CMPLTU, 0, X0): case OE_RRR(V1CMPLTU, 0, X1): + return TILEGX_EXCP_OPCODE_UNIMPLEMENTED; case OE_RRR(V1CMPNE, 0, X0): case OE_RRR(V1CMPNE, 0, X1): + tcg_gen_xor_tl(tdest, tsrca, tsrcb); + gen_v1cmpne0(tdest); + mnemonic = "v1cmpne"; + break; case OE_RRR(V1DDOTPUA, 0, X0): case OE_RRR(V1DDOTPUSA, 0, X0): case OE_RRR(V1DDOTPUS, 0, X0): @@ -1187,6 +1234,10 @@ static TileExcp gen_rri_opcode(DisasContext *dc, unsigned opext, case OE_IM(V1ADDI, X1): case OE_IM(V1CMPEQI, X0): case OE_IM(V1CMPEQI, X1): + tcg_gen_xori_tl(tdest, tsrca, V1_IMM(imm)); + gen_v1cmpeq0(tdest); + mnemonic = "v1cmpeqi"; + break; case OE_IM(V1CMPLTSI, X0): case OE_IM(V1CMPLTSI, X1): case OE_IM(V1CMPLTUI, X0):