| Message ID | 1440540624-7998-2-git-send-email-marcandre.lureau@redhat.com |
|---|---|
| State | New |
| Headers | show |
Quoting marcandre.lureau@redhat.com (2015-08-25 17:10:13) > From: Marc-André Lureau <marcandre.lureau@redhat.com> > > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com> > --- > qga/qapi-schema.json | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json > index 18e3cc3..6b0bd16 100644 > --- a/qga/qapi-schema.json > +++ b/qga/qapi-schema.json > @@ -793,7 +793,7 @@ > # scheme. Refer to the documentation of the guest operating system > # in question to determine what is supported. > # > -# Note all guest operating systems will support use of the > +# Not all guest operating systems will support use of the > # @crypted flag, as they may require the clear-text password > # > # The @password parameter must always be base64 encoded before > -- > 2.4.3 >
On 08/25/2015 04:10 PM, marcandre.lureau@redhat.com wrote: > From: Marc-André Lureau <marcandre.lureau@redhat.com> > > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> > --- > qga/qapi-schema.json | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This already had Reviewed-by in version 1: http://thread.gmane.org/gmane.comp.emulators.qemu/347998/focus=347997 It's best to edit your commit message and manually add in that notation, when sending a v2, so that reviewers know that nothing changed since last time they approved it: http://wiki.qemu.org/Contribute/SubmitAPatch [and while trying to write this email, I ran into an "Internal Server Error" when trying to view https://lists.gnu.org/archive/html/qemu-devel/2015-07/threads.html; I don't know if the problem is transient, or if the webmasters at nongnu.org know what is going on, but it would be a shame if our archives can't be restored to working order]
Hi On Wed, Aug 26, 2015 at 12:30 AM, Eric Blake <eblake@redhat.com> wrote: > It's best to edit your commit message and manually add in that notation, > when sending a v2, so that reviewers know that nothing changed since > last time they approved it: > http://wiki.qemu.org/Contribute/SubmitAPatch Weird, I thought I did it (see other patches), anyway, I'll added them now.
diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json index 18e3cc3..6b0bd16 100644 --- a/qga/qapi-schema.json +++ b/qga/qapi-schema.json @@ -793,7 +793,7 @@ # scheme. Refer to the documentation of the guest operating system # in question to determine what is supported. # -# Note all guest operating systems will support use of the +# Not all guest operating systems will support use of the # @crypted flag, as they may require the clear-text password # # The @password parameter must always be base64 encoded before