From patchwork Mon Aug 10 15:27:16 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: fred.konrad@greensocs.com X-Patchwork-Id: 505699 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 6D79514012C for ; Tue, 11 Aug 2015 01:41:06 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=greensocs.com header.i=@greensocs.com header.b=gL6Q64XW; dkim=fail reason="signature verification failed" (1024-bit key) header.d=greensocs.com header.i=@greensocs.com header.b=38esGkIT; dkim-atps=neutral Received: from localhost ([::1]:58970 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZOpCC-0002bs-MM for incoming@patchwork.ozlabs.org; Mon, 10 Aug 2015 11:41:04 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39937) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZOozs-00079x-Ul for qemu-devel@nongnu.org; Mon, 10 Aug 2015 11:28:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZOozq-00009t-VT for qemu-devel@nongnu.org; Mon, 10 Aug 2015 11:28:20 -0400 Received: from greensocs.com ([193.104.36.180]:59390) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZOozq-00009j-LK for qemu-devel@nongnu.org; Mon, 10 Aug 2015 11:28:18 -0400 Received: from localhost (localhost [127.0.0.1]) by greensocs.com (Postfix) with ESMTP id 1461518DEE3; Mon, 10 Aug 2015 17:28:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=greensocs.com; s=mail; t=1439220498; bh=Ar8okD6dOSFQbVKmj5ebnJrRtYQ4rPj6j/68VEldDE0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=gL6Q64XWDFngxxhJ4SJcU4b8ZS2WgSQ6kgr9klpgwvTGyEbqNCS+DhO1K1QOUDwCm 7kq0UkX6Fi62e4e1eNN8AKwwEXFFFPUCpbEqKbeofWUX7yPF1RqJvK4YAux5XspWAY 0sIYUffqNhYmtmYwbq//bSHPRsuKoQKVtVNdXg5Y= X-Virus-Scanned: amavisd-new at greensocs.com Authentication-Results: gs-01.greensocs.com (amavisd-new); dkim=pass (1024-bit key) header.d=greensocs.com Received: from greensocs.com ([127.0.0.1]) by localhost (gs-01.greensocs.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id S8D0CJHPX8zD; Mon, 10 Aug 2015 17:28:14 +0200 (CEST) Received: from localhost.localdomain (AToulouse-555-1-147-173.w109-223.abo.wanadoo.fr [109.223.34.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: fred.konrad@greensocs.com) by greensocs.com (Postfix) with ESMTPSA id 84F5F18DEE4; Mon, 10 Aug 2015 17:27:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=greensocs.com; s=mail; t=1439220456; bh=Ar8okD6dOSFQbVKmj5ebnJrRtYQ4rPj6j/68VEldDE0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=38esGkITsJV6LHJP2BOJCac/HCsOlH0NTzm6Nh3eUePXN8GV/rGj6ApErLbWo4e3f yQLUAsZcgHCeFy0Oj9GErV07FOvT7316RXQWf6JDFX7Nr8RQL5YhBK1wqJyGKMLd+c IB9StG0GuYSmj5RU21onP1+ZcJpAyCt9vuLe60xI= From: fred.konrad@greensocs.com To: qemu-devel@nongnu.org, mttcg@listserver.greensocs.com Date: Mon, 10 Aug 2015 17:27:16 +0200 Message-Id: <1439220437-23957-19-git-send-email-fred.konrad@greensocs.com> X-Mailer: git-send-email 1.9.0 In-Reply-To: <1439220437-23957-1-git-send-email-fred.konrad@greensocs.com> References: <1439220437-23957-1-git-send-email-fred.konrad@greensocs.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 193.104.36.180 Cc: mark.burton@greensocs.com, a.rigo@virtualopensystems.com, guillaume.delbergue@greensocs.com, pbonzini@redhat.com, alex.bennee@linaro.org, fred.konrad@greensocs.com Subject: [Qemu-devel] [RFC PATCH V7 18/19] mttcg: signal the associated cpu anyway. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: KONRAD Frederic We might have a race here. If current_cpu is about to be set then cpu_exit won't be called and we don't exit TCG. This was probably an issue with old implementation as well. Signed-off-by: KONRAD Frederic --- cpus.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/cpus.c b/cpus.c index 2c5ca72..f61530c 100644 --- a/cpus.c +++ b/cpus.c @@ -674,8 +674,7 @@ static void cpu_signal(int sig) cpu_exit(current_cpu); } - /* FIXME: We might want to check if the cpu is running? */ - tcg_thread_cpu->exit_request = true; + cpu_exit(tcg_thread_cpu); } #ifdef CONFIG_LINUX