From patchwork Mon Aug 3 17:54:24 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Leonid Bloch X-Patchwork-Id: 503256 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 1F1F91401C7 for ; Tue, 4 Aug 2015 03:55:25 +1000 (AEST) Received: from localhost ([::1]:60112 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMJxL-0003wR-5C for incoming@patchwork.ozlabs.org; Mon, 03 Aug 2015 13:55:23 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38792) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMJwv-0003G4-OP for qemu-devel@nongnu.org; Mon, 03 Aug 2015 13:54:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZMJwt-0003i3-0v for qemu-devel@nongnu.org; Mon, 03 Aug 2015 13:54:57 -0400 Received: from mail-wi0-f171.google.com ([209.85.212.171]:36624) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMJws-0003hc-Ow for qemu-devel@nongnu.org; Mon, 03 Aug 2015 13:54:54 -0400 Received: by wicgj17 with SMTP id gj17so116258329wic.1 for ; Mon, 03 Aug 2015 10:54:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=zDBp2ePKD/Ps1coEcwWoMSP0wgQeRN+Fsio7jraQI/M=; b=IK2b6y/o9st227L5Smp3+p29ctPeB2cVE4NzclpIBFjPD8iS2LcyAHCcztswECmF1s JAmT6zOcGrikSB/kH8K1gfnG60qdiaVe6VTOaeMm9tOcBOFPFiBFyG8zmAY3YofU+N8b 4T9QzVRsCVGuL15H+ATfTrSzjfhnSevpDsTpyTMxNivJXBrV/eUkdjCi2cztT7cwBXC4 LDBklfmLRLTdp+RdUrkzzufhZpwK2UWCgLNKJimT5FfFPhigaOgUXVY+WTRJPNMkp+38 RVwAMBcS/qMI4A1tPlrzUJru7XqkxSGEyYjSoqs1hopDY9itX6LSQEsy92kg8zGjHj3D aXug== X-Gm-Message-State: ALoCoQn5FSqjT5DBjB7VrQT6WiWJ16pZ2sPvFUHL7bIp4DZsOWjyZ201LfXiGgJQsw+b6fu0Z/QG X-Received: by 10.180.84.230 with SMTP id c6mr36297959wiz.32.1438624494162; Mon, 03 Aug 2015 10:54:54 -0700 (PDT) Received: from bark.daynix ([5.102.236.99]) by smtp.gmail.com with ESMTPSA id ev2sm14667474wib.21.2015.08.03.10.54.52 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Aug 2015 10:54:53 -0700 (PDT) From: Leonid Bloch To: qemu-devel@nongnu.org Date: Mon, 3 Aug 2015 20:54:24 +0300 Message-Id: <1438624464-22770-5-git-send-email-leonid@daynix.com> X-Mailer: git-send-email 2.4.3 In-Reply-To: <1438624464-22770-1-git-send-email-leonid@daynix.com> References: <1438624464-22770-1-git-send-email-leonid@daynix.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.212.171 Cc: Leonid Bloch , marcandre.lureau@gmail.com Subject: [Qemu-devel] [PATCH v3 4/4] qemu-ga: Prevent QEMU-GA VSS provider from being unregistered on MSI reinstall X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Previously, running the .msi would unregister the QEMU GA VSS service if QEMU GA was already installed on the machine, and then register it only if QEMU GA was NOT previously installed. This behavior caused the service to be registered only after the INITIAL installation, and any subsequent run of the .msi (to redo, repair, or upgrade the installation) ended in the service being unregistered. Now, the VSS service is still unregistered if QEMU GA is already installed (so that a fix or an update could be performed) but then it is registered again (if the GA is not being uninstalled) thus finishing the repair/upgrade correctly. Additionally, downgrading is now prevented. If a user would like to downgrade a version, he/she must uninstall the newer version first. Signed-off-by: Leonid Bloch Reviewed-by: Marc-André Lureau --- qga/installer/qemu-ga.wxs | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/qga/installer/qemu-ga.wxs b/qga/installer/qemu-ga.wxs index 2302745..41b11cf 100644 --- a/qga/installer/qemu-ga.wxs +++ b/qga/installer/qemu-ga.wxs @@ -58,13 +58,9 @@ /> - - - - + @@ -125,6 +121,7 @@ + - - NOT Installed Installed + NOT REMOVE