From patchwork Tue Jul 28 18:44:50 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shmulik Ladkani X-Patchwork-Id: 501366 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id A2D85140DFC for ; Wed, 29 Jul 2015 04:45:30 +1000 (AEST) Received: from localhost ([::1]:60370 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZK9sV-0002qA-Oz for incoming@patchwork.ozlabs.org; Tue, 28 Jul 2015 14:45:27 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38650) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZK9sF-0002WQ-W1 for qemu-devel@nongnu.org; Tue, 28 Jul 2015 14:45:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZK9sC-0007YY-Qd for qemu-devel@nongnu.org; Tue, 28 Jul 2015 14:45:11 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:34397) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZK9sC-0007Vs-L6 for qemu-devel@nongnu.org; Tue, 28 Jul 2015 14:45:08 -0400 Received: by wibud3 with SMTP id ud3so192473466wib.1 for ; Tue, 28 Jul 2015 11:45:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=pNzNYoJ39OUxR4kddbQ7rMhm/CjRQbZZPT6LSxfMvS0=; b=KRqTPJBFqrdyMdJIkesQDzmmSDbIE0Q7blgMzbM7LpEHnC5qrajXPAIHvxwykS2CcD tkeQZxEERCzJKy+DLTBl2f55zen5jvu7I/wNg5aokb3lAOCqF4/DZA6i2EagqJBOv7bs UacgUY/ZXw4UvOpQqgxf1/Pdz4NjNfmOay4Ds4zI/IVwjiFZ5e70Poh3HHSCLacTB80u NKppBfDI3pA+8mGtqzYrv5++j+4w9aniibUmtkI2nVNHuHq3JSoR2SJ4ycR0cDjosItR xn6V9V9c9HyoJz5lrjSXhV8qzfKcbZYdijUWy4oLn9fmRescO0yMBXeuBMAkWEP9DxPF cr0A== X-Gm-Message-State: ALoCoQm7FcieDWwdow5XpAiuqLPstBPdXzN2T+Hb0+3t8Xxxn5WcNDMQbZGpfcoy4IBABPYKw7JX X-Received: by 10.180.88.196 with SMTP id bi4mr38479224wib.70.1438109106706; Tue, 28 Jul 2015 11:45:06 -0700 (PDT) Received: from pixies.home ([5.102.218.239]) by smtp.gmail.com with ESMTPSA id d7sm20372892wij.0.2015.07.28.11.45.04 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 28 Jul 2015 11:45:05 -0700 (PDT) From: Shmulik Ladkani To: qemu-devel@nongnu.org, Dmitry Fleytman , Stefan Hajnoczi Date: Tue, 28 Jul 2015 21:44:50 +0300 Message-Id: <1438109090-18957-1-git-send-email-shmulik.ladkani@ravellosystems.com> X-Mailer: git-send-email 1.9.1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.212.182 Cc: Dana Rubin , Shmulik Ladkani Subject: [Qemu-devel] [PATCH] net/vmxnet3: Fix incorrect debug message X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Dana Rubin From: Dana Rubin In commit 80da311d81, "net/vmxnet3: Fix RX TCP/UDP checksum on partially summed packets" a debug message was introduced in vmxnet3_rx_need_csum_calculate() for an unlikely input condition. The message accidentally printed 'len' variable instead of 'pkt_len'. Fix, providing the correct argument. Signed-off-by: Dana Rubin Signed-off-by: Shmulik Ladkani --- hw/net/vmxnet3.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index 59b06b8..071feeb 100644 --- a/hw/net/vmxnet3.c +++ b/hw/net/vmxnet3.c @@ -927,9 +927,9 @@ static void vmxnet3_rx_need_csum_calculate(struct VmxnetRxPkt *pkt, /* Validate packet len: csum_start + scum_offset + length of csum field */ if (pkt_len < (vhdr->csum_start + vhdr->csum_offset + 2)) { - VMW_PKPRN("packet len:%d < csum_start(%d) + csum_offset(%d) + 2, " + VMW_PKPRN("packet len:%lu < csum_start(%d) + csum_offset(%d) + 2, " "cannot calculate checksum", - len, vhdr->csum_start, vhdr->csum_offset); + pkt_len, vhdr->csum_start, vhdr->csum_offset); return; }