From patchwork Tue Jul 28 00:32:48 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Patchwork-Id: 500970 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3C16D1402BA for ; Tue, 28 Jul 2015 10:45:05 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=V/L78OV5; dkim-atps=neutral Received: from localhost ([::1]:56444 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJt0x-00035X-EE for incoming@patchwork.ozlabs.org; Mon, 27 Jul 2015 20:45:03 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48031) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJss2-0002Y9-05 for qemu-devel@nongnu.org; Mon, 27 Jul 2015 20:35:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZJsry-00066z-Ey for qemu-devel@nongnu.org; Mon, 27 Jul 2015 20:35:49 -0400 Received: from mail-qk0-x22d.google.com ([2607:f8b0:400d:c09::22d]:34506) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJsrx-00066q-N3 for qemu-devel@nongnu.org; Mon, 27 Jul 2015 20:35:46 -0400 Received: by qkfc129 with SMTP id c129so45945498qkf.1 for ; Mon, 27 Jul 2015 17:35:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=cgBOYQaUIxuGV4TRDEdYM7zpMW8zAh5/L/G7hLwdFmg=; b=V/L78OV5NBqI8JKmGet+gdcbjSmI5RT7rQNwnQ2w32NDvDs3cI+Twe1xs3iHagv0q0 IhM4yyDMY8e6+CHmo+xzDc9FcWDf6hY6e3nyT+MgUUqZPSbFhUsjT2bNBnhVLshUau90 vTSwSSEtIRR1nC37EQWhWq1C+CCjvWvYGRDFYOTNIHuvxcFux8lnmf+4jk0TiRnxijun gzC9lfhJGgdaVfF9S8xy9xjF/Iw9QUeTYZvx/Z2V67oR69l8R1/kQl1NnrsaxrLgG1aV if6vrc69JkuM8af9vQ8pvhFlaGV+LRSTe+o4ZFc4A8LYa3+ZDR3nhrDSMtdwKPWzxL7e f0ag== X-Received: by 10.55.17.170 with SMTP id 42mr41074423qkr.29.1438043745450; Mon, 27 Jul 2015 17:35:45 -0700 (PDT) Received: from localhost (APoitiers-257-1-37-212.w90-38.abo.wanadoo.fr. [90.38.212.212]) by smtp.gmail.com with ESMTPSA id d9sm10288921qga.6.2015.07.27.17.35.44 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Jul 2015 17:35:44 -0700 (PDT) From: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= To: qemu-devel@nongnu.org Date: Tue, 28 Jul 2015 02:32:48 +0200 Message-Id: <1438043577-28636-37-git-send-email-marcandre.lureau@redhat.com> X-Mailer: git-send-email 2.4.3 In-Reply-To: <1438043577-28636-1-git-send-email-marcandre.lureau@redhat.com> References: <1438043577-28636-1-git-send-email-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400d:c09::22d Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , drjones@redhat.com, cam@cs.ualberta.ca, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , stefanha@redhat.com Subject: [Qemu-devel] [PATCH v2 36/45] contrib: remove unnecessary strdup() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Marc-André Lureau getopt() optarg points to argv memory, no need to dup those values, fixes small leaks detected by clang-analyzer. Signed-off-by: Marc-André Lureau --- contrib/ivshmem-client/main.c | 2 +- contrib/ivshmem-server/main.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/contrib/ivshmem-client/main.c b/contrib/ivshmem-client/main.c index 5d85ae7..bd7cbfc 100644 --- a/contrib/ivshmem-client/main.c +++ b/contrib/ivshmem-client/main.c @@ -53,7 +53,7 @@ ivshmem_client_parse_args(IvshmemClientArgs *args, int argc, char *argv[]) break; case 'S': /* unix_sock_path */ - args->unix_sock_path = strdup(optarg); + args->unix_sock_path = optarg; break; default: diff --git a/contrib/ivshmem-server/main.c b/contrib/ivshmem-server/main.c index cd8d9ed..71e87ea 100644 --- a/contrib/ivshmem-server/main.c +++ b/contrib/ivshmem-server/main.c @@ -92,15 +92,15 @@ ivshmem_server_parse_args(IvshmemServerArgs *args, int argc, char *argv[]) break; case 'p': /* pid_file */ - args->pid_file = strdup(optarg); + args->pid_file = optarg; break; case 'S': /* unix_socket_path */ - args->unix_socket_path = strdup(optarg); + args->unix_socket_path = optarg; break; case 'm': /* shm_path */ - args->shm_path = strdup(optarg); + args->shm_path = optarg; break; case 'l': /* shm_size */