From patchwork Wed Jul 15 20:02:02 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eduardo Habkost X-Patchwork-Id: 495992 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 410931409A0 for ; Thu, 16 Jul 2015 06:02:40 +1000 (AEST) Received: from localhost ([::1]:37266 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFSt4-0004uP-8l for incoming@patchwork.ozlabs.org; Wed, 15 Jul 2015 16:02:38 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48431) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFSsg-0004JV-W7 for qemu-devel@nongnu.org; Wed, 15 Jul 2015 16:02:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZFSsc-0000KO-Te for qemu-devel@nongnu.org; Wed, 15 Jul 2015 16:02:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56343) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFSsc-0000KJ-P8 for qemu-devel@nongnu.org; Wed, 15 Jul 2015 16:02:10 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 4E50519CB8A; Wed, 15 Jul 2015 20:02:10 +0000 (UTC) Received: from localhost (ovpn-113-45.phx2.redhat.com [10.3.113.45]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t6FK29B6018487; Wed, 15 Jul 2015 16:02:09 -0400 From: Eduardo Habkost To: Peter Maydell Date: Wed, 15 Jul 2015 17:02:02 -0300 Message-Id: <1436990522-22700-2-git-send-email-ehabkost@redhat.com> In-Reply-To: <1436990522-22700-1-git-send-email-ehabkost@redhat.com> References: <1436990522-22700-1-git-send-email-ehabkost@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: qemu-devel@nongnu.org, Bharata B Rao Subject: [Qemu-devel] [PULL 1/1] numa: Fix memory leak in numa_set_mem_node_id() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Bharata B Rao Fix a memory leak in numa_set_mem_node_id(). Signed-off-by: Bharata B Rao Reported-by: Paolo Bonzini Reviewed-by: Eduardo Habkost Signed-off-by: Eduardo Habkost --- numa.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/numa.c b/numa.c index 3c80059..402804b 100644 --- a/numa.c +++ b/numa.c @@ -54,7 +54,7 @@ NodeInfo numa_info[MAX_NODES]; void numa_set_mem_node_id(ram_addr_t addr, uint64_t size, uint32_t node) { - struct numa_addr_range *range = g_malloc0(sizeof(*range)); + struct numa_addr_range *range; /* * Memory-less nodes can come here with 0 size in which case, @@ -64,6 +64,7 @@ void numa_set_mem_node_id(ram_addr_t addr, uint64_t size, uint32_t node) return; } + range = g_malloc0(sizeof(*range)); range->mem_start = addr; range->mem_end = addr + size - 1; QLIST_INSERT_HEAD(&numa_info[node].addr, range, entry);