diff mbox

qcow2: remove unnecessary check

Message ID 1435824371-2660-1-git-send-email-berto@igalia.com
State New
Headers show

Commit Message

Alberto Garcia July 2, 2015, 8:06 a.m. UTC
The value of 'i' is guaranteed to be >= 0

Signed-off-by: Alberto Garcia <berto@igalia.com>
---
 block/qcow2-cache.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Stefan Hajnoczi July 2, 2015, 2:17 p.m. UTC | #1
On Thu, Jul 02, 2015 at 11:06:11AM +0300, Alberto Garcia wrote:
> The value of 'i' is guaranteed to be >= 0
> 
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
>  block/qcow2-cache.c | 3 ---
>  1 file changed, 3 deletions(-)

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan
diff mbox

Patch

diff --git a/block/qcow2-cache.c b/block/qcow2-cache.c
index ed92a09..53b8afc 100644
--- a/block/qcow2-cache.c
+++ b/block/qcow2-cache.c
@@ -281,9 +281,6 @@  static int qcow2_cache_do_get(BlockDriverState *bs, Qcow2Cache *c,
     i = min_lru_index;
     trace_qcow2_cache_get_replace_entry(qemu_coroutine_self(),
                                         c == s->l2_table_cache, i);
-    if (i < 0) {
-        return i;
-    }
 
     ret = qcow2_cache_entry_flush(bs, c, i);
     if (ret < 0) {