| Message ID | 1435717587-18155-1-git-send-email-famz@redhat.com |
|---|---|
| State | New |
| Headers | show |
On Wed, Jul 01, 2015 at 10:26:27AM +0800, Fam Zheng wrote: > Commit 6e99c63 ("net/socket: Drop net_socket_can_send") changed the > semantics around .can_receive for sockets to now require the device to > flush queued pkts when transitioning to a .can_receive=true state. But > it's OK to drop incoming packets when the link is not active. > > Signed-off-by: Fam Zheng <famz@redhat.com> > --- > hw/net/vmxnet3.c | 1 - > 1 file changed, 1 deletion(-) Thanks, applied to my net tree: https://github.com/stefanha/qemu/commits/net Stefan
On Wed, Jul 01, 2015 at 10:26:27AM +0800, Fam Zheng wrote: > Commit 6e99c63 ("net/socket: Drop net_socket_can_send") changed the > semantics around .can_receive for sockets to now require the device to > flush queued pkts when transitioning to a .can_receive=true state. But > it's OK to drop incoming packets when the link is not active. > > Signed-off-by: Fam Zheng <famz@redhat.com> > --- > hw/net/vmxnet3.c | 1 - > 1 file changed, 1 deletion(-) Sorry, this was dropped when waiting to see how the .can_receive() stuff would end up for QEMU 2.4. Thanks, applied to my net tree: https://github.com/stefanha/qemu/commits/net Stefan
diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index 104a0f5..12ae30f 100644 --- a/hw/net/vmxnet3.c +++ b/hw/net/vmxnet3.c @@ -1929,7 +1929,6 @@ static void vmxnet3_set_link_status(NetClientState *nc) static NetClientInfo net_vmxnet3_info = { .type = NET_CLIENT_OPTIONS_KIND_NIC, .size = sizeof(NICState), - .can_receive = vmxnet3_can_receive, .receive = vmxnet3_receive, .link_status_changed = vmxnet3_set_link_status, };
Commit 6e99c63 ("net/socket: Drop net_socket_can_send") changed the semantics around .can_receive for sockets to now require the device to flush queued pkts when transitioning to a .can_receive=true state. But it's OK to drop incoming packets when the link is not active. Signed-off-by: Fam Zheng <famz@redhat.com> --- hw/net/vmxnet3.c | 1 - 1 file changed, 1 deletion(-)