From patchwork Mon Jun 29 05:36:54 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Gibson X-Patchwork-Id: 489211 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id D70FD14076A for ; Mon, 29 Jun 2015 15:36:56 +1000 (AEST) Received: from localhost ([::1]:40626 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9RkV-0006c9-0u for incoming@patchwork.ozlabs.org; Mon, 29 Jun 2015 01:36:55 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55640) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9Rjz-0005ba-CQ for qemu-devel@nongnu.org; Mon, 29 Jun 2015 01:36:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z9Rjw-0003T8-3z for qemu-devel@nongnu.org; Mon, 29 Jun 2015 01:36:23 -0400 Received: from ozlabs.org ([103.22.144.67]:48813) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9Rjv-0003R2-P4; Mon, 29 Jun 2015 01:36:20 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id B9DFE14077A; Mon, 29 Jun 2015 15:36:12 +1000 (AEST) From: David Gibson To: agraf@suse.de, armbru@redhat.com, lcapitulino@redhat.com Date: Mon, 29 Jun 2015 15:36:54 +1000 Message-Id: <1435556214-2916-5-git-send-email-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.4.3 In-Reply-To: <1435556214-2916-1-git-send-email-david@gibson.dropbear.id.au> References: <1435556214-2916-1-git-send-email-david@gibson.dropbear.id.au> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 103.22.144.67 Cc: lvivier@redhat.com, thuth@redhat.com, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, afaerber@suse.de, David Gibson Subject: [Qemu-devel] [PATCH 4/4] Disable "info irq" and "info pic" for target-ppc X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org The "info irq" and "info pic" HMP commands are available on some, but not all targets, and what they do isn't terribly consistent. For SPARC and LM32 they do something platform specific, but for x86, powerpc, and MIPS they print some information from the i8259 (and only the i8259) interrupt controller. It's debatable whether these commands are any use at all, and we should probably make better, qdev aware ways of getting information from a machines PICs. However, those don't exist yet, so on x86 it's at least potentially useful to have these HMP commands. I can't speak for MIPS. For ppc, though, the i8259, if it exists at all, is usually just a secondary controller for legacy ISA. The only case where i8259 is the main system PIC on ppc is for the ancient and little-used PReP platform. So, even without QOM-ish replacement, the info pic and info irq HMP commands have no value on ppc. This patch, therefore, disables these commands for ppc targets. This will allow ppc builds which don't include PReP to not include ISA bus support either. Signed-off-by: David Gibson --- monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/monitor.c b/monitor.c index aeea2b5..8c56bfa 100644 --- a/monitor.c +++ b/monitor.c @@ -2573,7 +2573,7 @@ static mon_cmd_t info_cmds[] = { .help = "show the command line history", .mhandler.cmd = hmp_info_history, }, -#if defined(TARGET_I386) || defined(TARGET_PPC) || defined(TARGET_MIPS) || \ +#if defined(TARGET_I386) || defined(TARGET_MIPS) || \ defined(TARGET_LM32) || (defined(TARGET_SPARC) && !defined(TARGET_SPARC64)) { .name = "irq",