| Message ID | 1435202570-12360-2-git-send-email-famz@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 25.06.2015 05:22, Fam Zheng wrote: > In block/backup.c, we already check and add blocker on the target bs, > which is necessary so that it won't be intervened with other operations. > > In block/mirror.c we should also protect the mirror target bs, because it > could have a node-name (drive-mirror ... node-name=XXX), and on top of > that it's safe to add blockdev-mirror. > > Signed-off-by: Fam Zheng <famz@redhat.com> > --- > block/mirror.c | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Max Reitz <mreitz@redhat.com>
diff --git a/block/mirror.c b/block/mirror.c index 33c640f..0afe585 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -360,6 +360,7 @@ static void mirror_exit(BlockJob *job, void *opaque) aio_context_release(replace_aio_context); } g_free(s->replaces); + bdrv_op_unblock_all(s->target, s->common.blocker); bdrv_unref(s->target); block_job_completed(&s->common, data->ret); g_free(data); @@ -695,6 +696,7 @@ static void mirror_start_job(BlockDriverState *bs, BlockDriverState *target, if (!s->dirty_bitmap) { return; } + bdrv_op_block_all(target, s->common.blocker); bdrv_set_enable_write_cache(s->target, true); if (s->target->blk) { blk_set_on_error(s->target->blk, on_target_error, on_target_error);
In block/backup.c, we already check and add blocker on the target bs, which is necessary so that it won't be intervened with other operations. In block/mirror.c we should also protect the mirror target bs, because it could have a node-name (drive-mirror ... node-name=XXX), and on top of that it's safe to add blockdev-mirror. Signed-off-by: Fam Zheng <famz@redhat.com> --- block/mirror.c | 2 ++ 1 file changed, 2 insertions(+)