From patchwork Fri Jun 12 10:09:21 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Hajnoczi X-Patchwork-Id: 483466 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 608221402B4 for ; Fri, 12 Jun 2015 20:12:21 +1000 (AEST) Received: from localhost ([::1]:50420 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z3Lwh-0001nY-Gh for incoming@patchwork.ozlabs.org; Fri, 12 Jun 2015 06:12:19 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58455) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z3LuE-0005rj-8X for qemu-devel@nongnu.org; Fri, 12 Jun 2015 06:09:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z3LuC-0006AS-FE for qemu-devel@nongnu.org; Fri, 12 Jun 2015 06:09:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54293) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z3LuC-0006A6-4Y for qemu-devel@nongnu.org; Fri, 12 Jun 2015 06:09:44 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id DB8BD8E717; Fri, 12 Jun 2015 10:09:43 +0000 (UTC) Received: from localhost (ovpn-112-61.ams2.redhat.com [10.36.112.61]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t5CA9g97007321; Fri, 12 Jun 2015 06:09:43 -0400 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Date: Fri, 12 Jun 2015 11:09:21 +0100 Message-Id: <1434103761-29871-10-git-send-email-stefanha@redhat.com> In-Reply-To: <1434103761-29871-1-git-send-email-stefanha@redhat.com> References: <1434103761-29871-1-git-send-email-stefanha@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: Kevin Wolf , famz@redhat.com, Jeff Cody , Max Reitz , vsementsov@parallels.com, Stefan Hajnoczi , John Snow Subject: [Qemu-devel] [RFC 9/9] qmp-commands.hx: Update the supported 'transaction' operations X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Kashyap Chamarthy Although the canonical source of reference for QMP commands is qapi-schema.json, for consistency's sake, update qmp-commands.hx to state the list of supported transactionable operations, namely: drive-backup blockdev-backup blockdev-snapshot-internal-sync abort block-dirty-bitmap-add block-dirty-bitmap-clear Signed-off-by: Kashyap Chamarthy Reviewed-by: Eric Blake Reviewed-by: Max Reitz Signed-off-by: John Snow Signed-off-by: Stefan Hajnoczi --- qmp-commands.hx | 21 ++++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/qmp-commands.hx b/qmp-commands.hx index 867a21f..cdab36c 100644 --- a/qmp-commands.hx +++ b/qmp-commands.hx @@ -1238,11 +1238,22 @@ SQMP transaction ----------- -Atomically operate on one or more block devices. The only supported operations -for now are drive-backup, internal and external snapshotting. A list of -dictionaries is accepted, that contains the actions to be performed. -If there is any failure performing any of the operations, all operations -for the group are abandoned. +Atomically operate on one or more block devices. Operations that are +currently supported: + + - drive-backup + - blockdev-backup + - blockdev-snapshot-sync + - blockdev-snapshot-internal-sync + - abort + - block-dirty-bitmap-add + - block-dirty-bitmap-clear + +Refer to the qemu/qapi-schema.json file for minimum required QEMU +versions for these operations. A list of dictionaries is accepted, +that contains the actions to be performed. If there is any failure +performing any of the operations, all operations for the group are +abandoned. For external snapshots, the dictionary contains the device, the file to use for the new snapshot, and the format. The default format, if not specified, is