diff mbox

configure: postfix --extra-cflags to QEMU_CFLAGS

Message ID 1433321798-13398-1-git-send-email-alex.bennee@linaro.org
State New
Headers show

Commit Message

Alex Bennée June 3, 2015, 8:56 a.m. UTC 
It makes sense that extra-cflags should be appended after the normal
CFLAGS so they don't get overridden by default behaviour. This way if
you specify something like:

  ./configure --extra-cflags="-O0"

You will see the requested behaviour.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Michael Tokarev June 3, 2015, 1:05 p.m. UTC | #1 
Applied to -trivial, thanks!

The other nearby case, --extra-ldflags, also wants this reordering :)

/mjt
Alex Bennée June 3, 2015, 1:23 p.m. UTC | #2 
Michael Tokarev <mjt@tls.msk.ru> writes:

> Applied to -trivial, thanks!
>
> The other nearby case, --extra-ldflags, also wants this reordering :)

sent

One day I'll find a use for such a thing but fortunately my default build
environment has everything I need ;-)

>
> /mjt
diff mbox

Patch

diff --git a/configure b/configure
index b707429..f13831a 100755
--- a/configure
+++ b/configure
@@ -353,7 +353,7 @@  for opt do
   ;;
   --cpu=*) cpu="$optarg"
   ;;
-  --extra-cflags=*) QEMU_CFLAGS="$optarg $QEMU_CFLAGS"
+  --extra-cflags=*) QEMU_CFLAGS="$QEMU_CFLAGS $optarg"
                     EXTRA_CFLAGS="$optarg"
   ;;
   --extra-ldflags=*) LDFLAGS="$optarg $LDFLAGS"