diff mbox

[v4,4/4] monitor: remove debug prints

Message ID 1433302122-27397-5-git-send-email-bsd@redhat.com
State New
Headers show

Commit Message

Bandan Das June 3, 2015, 3:28 a.m. UTC 
The preferred solution is to use tracepoints and there
is good chance of bitrot with the debug prints not being
enabled at compile time. Remove them.

Suggested-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Bandan Das <bsd@redhat.com>
---
 monitor.c | 19 +------------------
 1 file changed, 1 insertion(+), 18 deletions(-)

Comments

Markus Armbruster June 3, 2015, 11:33 a.m. UTC | #1 
Bandan Das <bsd@redhat.com> writes:

> The preferred solution is to use tracepoints and there
> is good chance of bitrot with the debug prints not being
> enabled at compile time. Remove them.
>
> Suggested-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Bandan Das <bsd@redhat.com>

Reviewed-by: Markus Armbruster <armbru@redhat.com>
diff mbox

Patch

diff --git a/monitor.c b/monitor.c
index cbc3cc6..44bd787 100644
--- a/monitor.c
+++ b/monitor.c
@@ -81,9 +81,6 @@ 
 #endif
 #include "hw/lm32/lm32_pic.h"
 
-//#define DEBUG
-//#define DEBUG_COMPLETION
-
 /*
  * Supported types:
  *
@@ -3700,9 +3697,6 @@  static const mon_cmd_t *monitor_parse_command(Monitor *mon,
     const mon_cmd_t *cmd;
     char cmdname[256];
 
-#ifdef DEBUG
-    monitor_printf(mon, "command='%s', start='%c'\n", cmdline, **cmdp);
-#endif
 
     /* extract the command name */
     p = get_command_name(*cmdp, cmdname, sizeof(cmdname));
@@ -4207,10 +4201,7 @@  static void file_completion(Monitor *mon, const char *input)
         path[input_path_len] = '\0';
         pstrcpy(file_prefix, sizeof(file_prefix), p + 1);
     }
-#ifdef DEBUG_COMPLETION
-    monitor_printf(mon, "input='%s' path='%s' prefix='%s'\n",
-                   input, path, file_prefix);
-#endif
+
     ffs = opendir(path);
     if (!ffs)
         return;
@@ -4788,14 +4779,6 @@  static void monitor_find_completion(void *opaque,
     if (parse_cmdline(cmdline, &nb_args, args) < 0) {
         return;
     }
-#ifdef DEBUG_COMPLETION
-    {
-        int i;
-        for (i = 0; i < nb_args; i++) {
-            monitor_printf(mon, "arg%d = '%s'\n", i, args[i]);
-        }
-    }
-#endif
 
     /* if the line ends with a space, it means we want to complete the
        next arg */