From patchwork Fri May 29 09:29:39 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cornelia Huck X-Patchwork-Id: 477711 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43C38140E55 for ; Fri, 29 May 2015 19:30:25 +1000 (AEST) Received: from localhost ([::1]:34613 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YyGcR-00038w-EC for incoming@patchwork.ozlabs.org; Fri, 29 May 2015 05:30:23 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60675) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YyGby-00029Z-N5 for qemu-devel@nongnu.org; Fri, 29 May 2015 05:29:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YyGbs-0001z7-Hi for qemu-devel@nongnu.org; Fri, 29 May 2015 05:29:54 -0400 Received: from e06smtp16.uk.ibm.com ([195.75.94.112]:47103) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YyGbs-0001yw-7w for qemu-devel@nongnu.org; Fri, 29 May 2015 05:29:48 -0400 Received: from /spool/local by e06smtp16.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 29 May 2015 10:29:47 +0100 Received: from d06dlp01.portsmouth.uk.ibm.com (9.149.20.13) by e06smtp16.uk.ibm.com (192.168.101.146) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 29 May 2015 10:29:44 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 9C38F17D805A for ; Fri, 29 May 2015 10:30:39 +0100 (BST) Received: from d06av11.portsmouth.uk.ibm.com (d06av11.portsmouth.uk.ibm.com [9.149.37.252]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t4T9Thrj21954772 for ; Fri, 29 May 2015 09:29:43 GMT Received: from d06av11.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av11.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t4T9TgRh016319 for ; Fri, 29 May 2015 03:29:43 -0600 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av11.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id t4T9TgUE016282; Fri, 29 May 2015 03:29:42 -0600 From: Cornelia Huck To: mst@redhat.com Date: Fri, 29 May 2015 11:29:39 +0200 Message-Id: <1432891780-46490-2-git-send-email-cornelia.huck@de.ibm.com> X-Mailer: git-send-email 2.3.7 In-Reply-To: <1432891780-46490-1-git-send-email-cornelia.huck@de.ibm.com> References: <1432891780-46490-1-git-send-email-cornelia.huck@de.ibm.com> X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15052909-0025-0000-0000-0000055CAB1A X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 195.75.94.112 Cc: Cornelia Huck , qemu-devel@nongnu.org Subject: [Qemu-devel] [PATCH 1/2] virtio-ccw: Don't advertise VIRTIO_F_BAD_FEATURE X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This was copied from virtio-pci, but it doesn't make much sense for ccw, as it doesn't have to handle the broken implementations this bit is supposed to deal with. Remove it. Signed-off-by: Cornelia Huck --- hw/s390x/virtio-ccw.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c index 0a35595..2d63764 100644 --- a/hw/s390x/virtio-ccw.c +++ b/hw/s390x/virtio-ccw.c @@ -1414,7 +1414,6 @@ static void virtio_ccw_device_plugged(DeviceState *d) sch->id.cu_model = virtio_bus_get_vdev_id(&dev->bus); virtio_add_feature(&vdev->host_features, VIRTIO_F_NOTIFY_ON_EMPTY); - virtio_add_feature(&vdev->host_features, VIRTIO_F_BAD_FEATURE); css_generate_sch_crws(sch->cssid, sch->ssid, sch->schid, d->hotplugged, 1);