From patchwork Thu May 7 15:16:58 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: phoeagon X-Patchwork-Id: 469714 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 1A9751401DA for ; Fri, 8 May 2015 01:17:31 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=Y72lkNjG; dkim-atps=neutral Received: from localhost ([::1]:51717 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YqNYH-0002Y0-AC for incoming@patchwork.ozlabs.org; Thu, 07 May 2015 11:17:29 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55119) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YqNY0-0002Fn-QA for qemu-devel@nongnu.org; Thu, 07 May 2015 11:17:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YqNXw-000765-SC for qemu-devel@nongnu.org; Thu, 07 May 2015 11:17:12 -0400 Received: from mail-pa0-x229.google.com ([2607:f8b0:400e:c03::229]:34915) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YqNXw-00075x-ME; Thu, 07 May 2015 11:17:08 -0400 Received: by pabtp1 with SMTP id tp1so42744584pab.2; Thu, 07 May 2015 08:17:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=lH2ojsfSYtYcgEv8t5KZ46aghznM68CqbgCGZND6gT8=; b=Y72lkNjGekv3QjUsSs14EEY0CB7seHdIkxa2KUXFa9t16/Ij7q/G/zNvG/fCaVi51I 7Do+AAyPi8aNuJylawg6TyyY68Py6mQR35AH+vF+MbQyE1AepAGKIimUYtMYavg8BhwH Y0g28K1CK5aR5OSu30BBdjM8GncBCazdnd5SRZZtkL0x3KfRYfqhf0X/QeMA/MtAaU9S Cg4rdBxYqnBcbMooOY9QMPoGteVoVbkG5Sgs4T4GdyxjZsYGvl5gRTJ4zYkuP3GssNpd eroqgfIL4XzD9RSfNyyZ2yzWb0twkvXesrkcJHBQFGntt7VFEorAiS71Ekq4RO4oK1nc SufQ== X-Received: by 10.66.159.106 with SMTP id xb10mr7575920pab.129.1431011827833; Thu, 07 May 2015 08:17:07 -0700 (PDT) Received: from localhost.localdomain (104.224.171.213.16clouds.com. [104.224.171.213]) by mx.google.com with ESMTPSA id h12sm2472709pdk.77.2015.05.07.08.17.04 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 07 May 2015 08:17:07 -0700 (PDT) From: Zhe Qiu To: qemu-devel@nongnu.org Date: Thu, 7 May 2015 23:16:58 +0800 Message-Id: <1431011818-15822-1-git-send-email-phoeagon@gmail.com> X-Mailer: git-send-email 2.4.0 In-Reply-To: <1430971496-32659-1-git-send-email-phoeagon@gmail.com> References: <1430971496-32659-1-git-send-email-phoeagon@gmail.com> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400e:c03::229 Cc: kwolf@redhat.com, Zhe Qiu , qemu-block@nongnu.org, sw@weilnetz.de, mreitz@redhat.com Subject: [Qemu-devel] [PATCH v4] block/vdi: Use bdrv_flush after metadata updates X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org In reference to b0ad5a45...078a458e, metadata writes to qcow2/cow/qcow/vpc/vmdk are all synced prior to succeeding writes. Only when write is successful that bdrv_flush is called. Signed-off-by: Zhe Qiu Reviewed-by: Max Reitz --- block/vdi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/vdi.c b/block/vdi.c index 7642ef3..dfe8ade 100644 --- a/block/vdi.c +++ b/block/vdi.c @@ -713,6 +713,9 @@ static int vdi_co_write(BlockDriverState *bs, logout("will write %u block map sectors starting from entry %u\n", n_sectors, bmap_first); ret = bdrv_write(bs->file, offset, base, n_sectors); + if (ret >= 0) { + ret = bdrv_flush(bs->file); + } } return ret;