Message ID | 1429629131-23800-1-git-send-email-thuth@redhat.com |
---|---|
State | New |
Headers | show |
On Tue, Apr 21, 2015 at 05:12:11PM +0200, Thomas Huth wrote: > The check "liobn & 0xFFFFFFFF00000000ULL" in spapr_tce_find_by_liobn() > is completely useless since liobn is only declared as an uint32_t > parameter. Fix this by using target_ulong instead (this is what most > of the callers of this function are using, too). > > Signed-off-by: Thomas Huth <thuth@redhat.com> Thanks. Adjusted for a conflict with Alexey's DDW preliminaries and applied to spapr-next.
diff --git a/hw/ppc/spapr_iommu.c b/hw/ppc/spapr_iommu.c index f3990fd..995f21b 100644 --- a/hw/ppc/spapr_iommu.c +++ b/hw/ppc/spapr_iommu.c @@ -41,7 +41,7 @@ enum sPAPRTCEAccess { static QLIST_HEAD(spapr_tce_tables, sPAPRTCETable) spapr_tce_tables; -static sPAPRTCETable *spapr_tce_find_by_liobn(uint32_t liobn) +static sPAPRTCETable *spapr_tce_find_by_liobn(target_ulong liobn) { sPAPRTCETable *tcet; @@ -52,7 +52,7 @@ static sPAPRTCETable *spapr_tce_find_by_liobn(uint32_t liobn) } QLIST_FOREACH(tcet, &spapr_tce_tables, list) { - if (tcet->liobn == liobn) { + if (tcet->liobn == (uint32_t)liobn) { return tcet; } }
The check "liobn & 0xFFFFFFFF00000000ULL" in spapr_tce_find_by_liobn() is completely useless since liobn is only declared as an uint32_t parameter. Fix this by using target_ulong instead (this is what most of the callers of this function are using, too). Signed-off-by: Thomas Huth <thuth@redhat.com> --- v2: - Do not change the hcall_dprintf() into a qemu_log_mask() statement. --- hw/ppc/spapr_iommu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)