diff mbox

linux-user: Correct TARGET_NR_timerfd to TARGET_NR_timerfd_create.

Message ID 1428524771-7566-1-git-send-email-T.E.Baldwin99@members.leeds.ac.uk
State New
Headers show

Commit Message

Timothy Baldwin April 8, 2015, 8:26 p.m. UTC 
Misspelled system call name in macro was causing timerfd_create not to be supported for the ARM target.
---
 linux-user/arm/syscall_nr.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Peter Maydell April 8, 2015, 8:30 p.m. UTC | #1 
On 8 April 2015 at 21:26, Timothy E Baldwin
<T.E.Baldwin99@members.leeds.ac.uk> wrote:
> Misspelled system call name in macro was causing timerfd_create not to be supported for the ARM target.
> ---
>  linux-user/arm/syscall_nr.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/linux-user/arm/syscall_nr.h b/linux-user/arm/syscall_nr.h
> index 7d7be7c..53552be 100644
> --- a/linux-user/arm/syscall_nr.h
> +++ b/linux-user/arm/syscall_nr.h
> @@ -354,7 +354,7 @@
>  #define TARGET_NR_kexec_load                   (347)
>  #define TARGET_NR_utimensat                    (348)
>  #define TARGET_NR_signalfd                     (349)
> -#define TARGET_NR_timerfd                      (350)
> +#define TARGET_NR_timerfd_create               (350)
>  #define TARGET_NR_eventfd                      (351)
>  #define TARGET_NR_fallocate                    (352)
>  #define TARGET_NR_timerfd_settime              (353)

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM
Peter Maydell April 8, 2015, 8:31 p.m. UTC | #2 
On 8 April 2015 at 21:30, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 8 April 2015 at 21:26, Timothy E Baldwin
> <T.E.Baldwin99@members.leeds.ac.uk> wrote:
>> Misspelled system call name in macro was causing timerfd_create not to be supported for the ARM target.
>> ---
>>  linux-user/arm/syscall_nr.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/linux-user/arm/syscall_nr.h b/linux-user/arm/syscall_nr.h
>> index 7d7be7c..53552be 100644
>> --- a/linux-user/arm/syscall_nr.h
>> +++ b/linux-user/arm/syscall_nr.h
>> @@ -354,7 +354,7 @@
>>  #define TARGET_NR_kexec_load                   (347)
>>  #define TARGET_NR_utimensat                    (348)
>>  #define TARGET_NR_signalfd                     (349)
>> -#define TARGET_NR_timerfd                      (350)
>> +#define TARGET_NR_timerfd_create               (350)
>>  #define TARGET_NR_eventfd                      (351)
>>  #define TARGET_NR_fallocate                    (352)
>>  #define TARGET_NR_timerfd_settime              (353)
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

...except I've just noticed you haven't added a
Signed-off-by: line in your commit message. We need
this, or we can't apply your patch.

(It would also be good to linewrap your commit messages
at 70-75 columns or so.)

thanks
-- PMM
diff mbox

Patch

diff --git a/linux-user/arm/syscall_nr.h b/linux-user/arm/syscall_nr.h
index 7d7be7c..53552be 100644
--- a/linux-user/arm/syscall_nr.h
+++ b/linux-user/arm/syscall_nr.h
@@ -354,7 +354,7 @@ 
 #define TARGET_NR_kexec_load			(347)
 #define TARGET_NR_utimensat			(348)
 #define TARGET_NR_signalfd			(349)
-#define TARGET_NR_timerfd			(350)
+#define TARGET_NR_timerfd_create		(350)
 #define TARGET_NR_eventfd			(351)
 #define TARGET_NR_fallocate			(352)
 #define TARGET_NR_timerfd_settime		(353)