| Message ID | 1426684909-95030-7-git-send-email-pbonzini@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 2015-03-18 14:21, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> A commit log should briefly state why we can do this safely (no state dependency, no need for locking). Yes, it's trivial in this case but already a little bit less trivial in case of the PM timer. > --- > exec.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/exec.c b/exec.c > index d60abfc..c1a2e9e 100644 > --- a/exec.c > +++ b/exec.c > @@ -2197,6 +2197,7 @@ static void memory_map_init(void) > system_io = g_malloc(sizeof(*system_io)); > memory_region_init_io(system_io, NULL, &unassigned_io_ops, NULL, "io", > 65536); > + memory_region_clear_global_locking(system_io); > address_space_init(&address_space_io, system_io, "I/O"); > > memory_listener_register(&core_memory_listener, &address_space_memory); > Jan
On 18/03/2015 15:33, Jan Kiszka wrote: > On 2015-03-18 14:21, Paolo Bonzini wrote: >> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > > A commit log should briefly state why we can do this safely (no state > dependency, no need for locking). Yes, it's trivial in this case but > already a little bit less trivial in case of the PM timer. Guilty as charged... Paolo >> --- >> exec.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/exec.c b/exec.c >> index d60abfc..c1a2e9e 100644 >> --- a/exec.c >> +++ b/exec.c >> @@ -2197,6 +2197,7 @@ static void memory_map_init(void) >> system_io = g_malloc(sizeof(*system_io)); >> memory_region_init_io(system_io, NULL, &unassigned_io_ops, NULL, "io", >> 65536); >> + memory_region_clear_global_locking(system_io); >> address_space_init(&address_space_io, system_io, "I/O"); >> >> memory_listener_register(&core_memory_listener, &address_space_memory); >> > > Jan >
diff --git a/exec.c b/exec.c index d60abfc..c1a2e9e 100644 --- a/exec.c +++ b/exec.c @@ -2197,6 +2197,7 @@ static void memory_map_init(void) system_io = g_malloc(sizeof(*system_io)); memory_region_init_io(system_io, NULL, &unassigned_io_ops, NULL, "io", 65536); + memory_region_clear_global_locking(system_io); address_space_init(&address_space_io, system_io, "I/O"); memory_listener_register(&core_memory_listener, &address_space_memory);
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> --- exec.c | 1 + 1 file changed, 1 insertion(+)