From patchwork Wed Mar 18 13:21:46 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 451456 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 30A8014007F for ; Thu, 19 Mar 2015 00:27:49 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="verification failed; unprotected key" header.d=gmail.com header.i=@gmail.com header.b=II+fHFZH; dkim-adsp=none (unprotected policy); dkim-atps=neutral Received: from localhost ([::1]:33652 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYE0h-0006VT-38 for incoming@patchwork.ozlabs.org; Wed, 18 Mar 2015 09:27:47 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60042) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYDvK-0003kZ-Db for qemu-devel@nongnu.org; Wed, 18 Mar 2015 09:22:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYDvE-0003do-KC for qemu-devel@nongnu.org; Wed, 18 Mar 2015 09:22:14 -0400 Received: from mail-we0-x22f.google.com ([2a00:1450:400c:c03::22f]:34961) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYDvE-0003db-6L for qemu-devel@nongnu.org; Wed, 18 Mar 2015 09:22:08 -0400 Received: by webcq43 with SMTP id cq43so32206057web.2 for ; Wed, 18 Mar 2015 06:22:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=P7EApFZRqHBut6rnqnCuKiLYV+aglSQQ3Fnglao8WuY=; b=II+fHFZHKP0h9waPjfm6LifFmSfgnZu/T/VrTxgpvwnQX8uu2Be38pUZs4f37q3XVO 9OyfSkA5U3dhtMD86fSyy5xyH+3uxr6ehvrTBGRgitjYfr70kgx3tpdxc5Iz2+oN89e/ 7FlV33Tzsr3DZlh5nnBvf5NiRO4cxlaGH2N+oO8fAQsh22sgEY77+B3LRNTR1BhqrFKy 0ygn9k3PyagItquJIL9JSwSO9FkrRXUTeG1XiteRGm5ntRInA8Txj2+wy4TKMeOL1bqL 2FTtfV5vZzq459OYRHdXcISbAi0Mj63hVSnYamaRCcIa1kG8jiJHvEawUeQU4nRacMbV 8khQ== X-Received: by 10.180.38.15 with SMTP id c15mr6909430wik.74.1426684927643; Wed, 18 Mar 2015 06:22:07 -0700 (PDT) Received: from localhost.localdomain (net-37-117-129-240.cust.vodafonedsl.it. [37.117.129.240]) by mx.google.com with ESMTPSA id m9sm3137704wiz.24.2015.03.18.06.22.05 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Mar 2015 06:22:06 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Wed, 18 Mar 2015 14:21:46 +0100 Message-Id: <1426684909-95030-6-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 2.3.0 In-Reply-To: <1426684909-95030-1-git-send-email-pbonzini@redhat.com> References: <1426684909-95030-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c03::22f Cc: Jan Kiszka Subject: [Qemu-devel] [PATCH 5/8] kvm: Switch to unlocked PIO X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Jan Kiszka Do not take the BQL before dispatching PIO requests of KVM VCPUs. Instead, call the unlocked version of address_space_rw. This enables completely BQL-free PIO handling in KVM mode for upcoming devices with fine-grained locking. Signed-off-by: Jan Kiszka Signed-off-by: Paolo Bonzini --- kvm-all.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index 8da1deb..2848e5b 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -1647,8 +1647,8 @@ static void kvm_handle_io(uint16_t port, void *data, int direction, int size, uint8_t *ptr = data; for (i = 0; i < count; i++) { - address_space_rw(&address_space_io, port, ptr, size, - direction == KVM_EXIT_IO_OUT); + address_space_rw_unlocked(&address_space_io, port, ptr, size, + direction == KVM_EXIT_IO_OUT); ptr += size; } } @@ -1804,13 +1804,11 @@ int kvm_cpu_exec(CPUState *cpu) switch (run->exit_reason) { case KVM_EXIT_IO: DPRINTF("handle_io\n"); - qemu_mutex_lock_iothread(); kvm_handle_io(run->io.port, (uint8_t *)run + run->io.data_offset, run->io.direction, run->io.size, run->io.count); - qemu_mutex_unlock_iothread(); ret = 0; break; case KVM_EXIT_MMIO: