From patchwork Sat Mar 14 16:00:44 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Weil X-Patchwork-Id: 450216 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 55E541400EA for ; Sun, 15 Mar 2015 03:02:17 +1100 (AEDT) Received: from localhost ([::1]:41264 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YWoVy-0003YE-QL for incoming@patchwork.ozlabs.org; Sat, 14 Mar 2015 12:02:14 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35831) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YWoUf-00024V-9F for qemu-devel@nongnu.org; Sat, 14 Mar 2015 12:00:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YWoUa-0000ca-AE for qemu-devel@nongnu.org; Sat, 14 Mar 2015 12:00:53 -0400 Received: from qemu.weilnetz.de ([37.221.198.45]:60051) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YWoUa-0000cG-57 for qemu-devel@nongnu.org; Sat, 14 Mar 2015 12:00:48 -0400 Received: by qemu.weilnetz.de (Postfix, from userid 1000) id F2EF017F713; Sat, 14 Mar 2015 17:00:44 +0100 (CET) From: Stefan Weil To: QEMU Developer Date: Sat, 14 Mar 2015 17:00:44 +0100 Message-Id: <1426348844-8793-1-git-send-email-sw@weilnetz.de> X-Mailer: git-send-email 1.7.10.4 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 37.221.198.45 Cc: Keith Busch , Kevin Wolf , Stefan Hajnoczi , Stefan Weil Subject: [Qemu-devel] [PATCH] nvme: Fix unintentional integer overflow (OVERFLOW_BEFORE_WIDEN) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org The shift operation on nlb gives a 32 bit result if no type cast is applied. This bug was reported by Coverity. Signed-off-by: Stefan Weil --- hw/block/nvme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 0f3dfb9..1e07166 100644 --- a/hw/block/nvme.c +++ b/hw/block/nvme.c @@ -222,7 +222,7 @@ static uint16_t nvme_rw(NvmeCtrl *n, NvmeNamespace *ns, NvmeCmd *cmd, uint8_t lba_index = NVME_ID_NS_FLBAS_INDEX(ns->id_ns.flbas); uint8_t data_shift = ns->id_ns.lbaf[lba_index].ds; - uint64_t data_size = nlb << data_shift; + uint64_t data_size = (uint64_t)nlb << data_shift; uint64_t aio_slba = slba << (data_shift - BDRV_SECTOR_BITS); int is_write = rw->opcode == NVME_CMD_WRITE ? 1 : 0;