| Message ID | 1424059780-7566-1-git-send-email-famz@redhat.com |
|---|---|
| State | New |
| Headers | show |
On Mon, Feb 16, 2015 at 12:09:40PM +0800, Fam Zheng wrote: > By default, we have ioeventfd enabled, so the IO request processing is > in IO thread; in the vcpu thread, guest mode is returned to as quickly > as possible, and completion is delivered via irqfd. Therefore this > comment from the initial implementation is barely relevant. > > Signed-off-by: Fam Zheng <famz@redhat.com> > --- > hw/block/virtio-blk.c | 6 ------ > 1 file changed, 6 deletions(-) Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
On Mon, 02/16 14:14, Stefan Hajnoczi wrote: > On Mon, Feb 16, 2015 at 12:09:40PM +0800, Fam Zheng wrote: > > By default, we have ioeventfd enabled, so the IO request processing is > > in IO thread; in the vcpu thread, guest mode is returned to as quickly > > as possible, and completion is delivered via irqfd. Therefore this > > comment from the initial implementation is barely relevant. > > > > Signed-off-by: Fam Zheng <famz@redhat.com> > > --- > > hw/block/virtio-blk.c | 6 ------ > > 1 file changed, 6 deletions(-) > > Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> Max, would you apply this? Fam
Am 16.02.2015 um 05:09 hat Fam Zheng geschrieben: > By default, we have ioeventfd enabled, so the IO request processing is > in IO thread; in the vcpu thread, guest mode is returned to as quickly > as possible, and completion is delivered via irqfd. Therefore this > comment from the initial implementation is barely relevant. > > Signed-off-by: Fam Zheng <famz@redhat.com> Thanks, applied to the block branch. Kevin
diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c index 1a8a176..29c8d33 100644 --- a/hw/block/virtio-blk.c +++ b/hw/block/virtio-blk.c @@ -591,12 +591,6 @@ static void virtio_blk_handle_output(VirtIODevice *vdev, VirtQueue *vq) if (mrb.num_reqs) { virtio_blk_submit_multireq(s->blk, &mrb); } - - /* - * FIXME: Want to check for completions before returning to guest mode, - * so cached reads and writes are reported as quickly as possible. But - * that should be done in the generic block layer. - */ } static void virtio_blk_dma_restart_bh(void *opaque)
By default, we have ioeventfd enabled, so the IO request processing is in IO thread; in the vcpu thread, guest mode is returned to as quickly as possible, and completion is delivered via irqfd. Therefore this comment from the initial implementation is barely relevant. Signed-off-by: Fam Zheng <famz@redhat.com> --- hw/block/virtio-blk.c | 6 ------ 1 file changed, 6 deletions(-)