From patchwork Tue Feb 10 04:36:15 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Gibson X-Patchwork-Id: 438181 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 53EF3140168 for ; Tue, 10 Feb 2015 15:36:27 +1100 (AEDT) Received: from localhost ([::1]:36952 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YL2Yj-0005Ky-Gl for incoming@patchwork.ozlabs.org; Mon, 09 Feb 2015 23:36:25 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49033) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YL2YJ-0004iX-Fa for qemu-devel@nongnu.org; Mon, 09 Feb 2015 23:36:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YL2YG-0003ZV-7k for qemu-devel@nongnu.org; Mon, 09 Feb 2015 23:35:59 -0500 Received: from ozlabs.org ([103.22.144.67]:35887) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YL2YF-0003XS-To; Mon, 09 Feb 2015 23:35:56 -0500 Received: by ozlabs.org (Postfix, from userid 1007) id 16B97140168; Tue, 10 Feb 2015 15:35:51 +1100 (AEDT) From: David Gibson To: agraf@suse.de, kraxel@redhat.com, benh@kernel.crashing.org Date: Tue, 10 Feb 2015 15:36:15 +1100 Message-Id: <1423542976-8825-2-git-send-email-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1423542976-8825-1-git-send-email-david@gibson.dropbear.id.au> References: <1423542976-8825-1-git-send-email-david@gibson.dropbear.id.au> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 103.22.144.67 Cc: aik@ozlabs.ru, qemu-ppc@nongnu.org, qemu-devel@nongnu.org, mdroth@us.ibm.com, David Gibson Subject: [Qemu-devel] [PATCH 1/2] vga: Expose framebuffer byteorder as a QOM property X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org The VGA device model now supports having the framebuffer in either endian, and can be switched between these by the guest via a register in the qext region. However, in some cases (e.g. LE OS on the pseries machine) we have existing guest that don't know about the endian switch register, but other parts of the qemu code have better information to set a default endianness than the VGA code does of itself. In order to allow them to set a correct default endianness in these cases, without breaking abstraction walls, this patch exposes the VGA framebuffer endianness via a writable QOM property. Signed-off-by: David Gibson prop fixup Reviewed-by: Gerd Hoffmann --- hw/display/vga-pci.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/hw/display/vga-pci.c b/hw/display/vga-pci.c index 53739e4..8bd6ff7 100644 --- a/hw/display/vga-pci.c +++ b/hw/display/vga-pci.c @@ -181,6 +181,20 @@ static void pci_vga_qext_write(void *ptr, hwaddr addr, } } +static bool vga_get_big_endian_fb(Object *obj, Error **errp) +{ + PCIVGAState *d = DO_UPCAST(PCIVGAState, dev, PCI_DEVICE(obj)); + + return d->vga.big_endian_fb; +} + +static void vga_set_big_endian_fb(Object *obj, bool value, Error **errp) +{ + PCIVGAState *d = DO_UPCAST(PCIVGAState, dev, PCI_DEVICE(obj)); + + d->vga.big_endian_fb = value; +} + static const MemoryRegionOps pci_vga_qext_ops = { .read = pci_vga_qext_read, .write = pci_vga_qext_write, @@ -233,6 +247,10 @@ static int pci_std_vga_initfn(PCIDevice *dev) vga_init_vbe(s, OBJECT(dev), pci_address_space(dev)); } + /* Expose framebuffer byteorder via QOM */ + object_property_add_bool(OBJECT(dev), "big-endian-framebuffer", + vga_get_big_endian_fb, vga_set_big_endian_fb, NULL); + return 0; } @@ -268,6 +286,10 @@ static int pci_secondary_vga_initfn(PCIDevice *dev) pci_register_bar(&d->dev, 0, PCI_BASE_ADDRESS_MEM_PREFETCH, &s->vram); pci_register_bar(&d->dev, 2, PCI_BASE_ADDRESS_SPACE_MEMORY, &d->mmio); + /* Expose framebuffer byteorder via QOM */ + object_property_add_bool(OBJECT(dev), "big-endian-framebuffer", + vga_get_big_endian_fb, vga_set_big_endian_fb, NULL); + return 0; }