Message ID | 1421917694-6824-4-git-send-email-mitake.hitoshi@lab.ntt.co.jp |
---|---|
State | New |
Headers | show
Return-Path: <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id EC12714017F for <incoming@patchwork.ozlabs.org>; Thu, 22 Jan 2015 20:12:19 +1100 (AEDT) Received: from localhost ([::1]:51907 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>) id 1YEDoI-0008E0-2d for incoming@patchwork.ozlabs.org; Thu, 22 Jan 2015 04:12:18 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34573) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <mitake.hitoshi@gmail.com>) id 1YEDlN-00031l-9k for qemu-devel@nongnu.org; Thu, 22 Jan 2015 04:09:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <mitake.hitoshi@gmail.com>) id 1YEDlM-0006Jg-HP for qemu-devel@nongnu.org; Thu, 22 Jan 2015 04:09:17 -0500 Received: from mail-pa0-x234.google.com ([2607:f8b0:400e:c03::234]:54049) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <mitake.hitoshi@gmail.com>) id 1YEDlL-0006Is-Uy for qemu-devel@nongnu.org; Thu, 22 Jan 2015 04:09:16 -0500 Received: by mail-pa0-f52.google.com with SMTP id kx10so548337pab.11 for <qemu-devel@nongnu.org>; Thu, 22 Jan 2015 01:09:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=kYNChO9Qz2S1gSeNy2r7P4zKatH5kcvmec2jzY5l4Ig=; b=ogGjCeLYJez2qMzxtnDuPeW1OTFs8MpiNpJcIMHBLirv34Qa72o5Q/MZexsWTb0hHR OfZ6C8GXcFsYAPBD14wzlzJ3ty2HntrNBsQ78TYBXQ4rpnDPqTM7Nh4d1l9spXqjk3m4 XZO44xkJfvOKaKIuMFtV5LjOsCQU1ffq3ff1N3q5KO9gJ1+RCW93zlifUvgp4f00P6B9 ySAdXI7GWZHXftabELc7wkFJd48R0nnKfutziG9zaNSXbcwW0v+9b3E1uSPM4XMKX8NT tNp8LxlwHu+Wqunmn7b9RzMDoO8VwCFmM56oqkVA3qzS8AcL0nLsWDugR5/1R6PFPrD/ BO5A== X-Received: by 10.66.254.68 with SMTP id ag4mr441147pad.39.1421917755001; Thu, 22 Jan 2015 01:09:15 -0800 (PST) Received: from localhost.localdomain (p12167-ipngn4801marunouchi.tokyo.ocn.ne.jp. [153.160.163.167]) by mx.google.com with ESMTPSA id ka5sm8265357pbc.27.2015.01.22.01.09.12 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 22 Jan 2015 01:09:14 -0800 (PST) From: Hitoshi Mitake <mitake.hitoshi@lab.ntt.co.jp> To: qemu-devel@nongnu.org Date: Thu, 22 Jan 2015 18:08:13 +0900 Message-Id: <1421917694-6824-4-git-send-email-mitake.hitoshi@lab.ntt.co.jp> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1421917694-6824-1-git-send-email-mitake.hitoshi@lab.ntt.co.jp> References: <1421917694-6824-1-git-send-email-mitake.hitoshi@lab.ntt.co.jp> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400e:c03::234 Cc: Hitoshi Mitake <mitake.hitoshi@lab.ntt.co.jp>, Michael Roth <mdroth@linux.vnet.ibm.com>, mitake.hitoshi@gmail.com, Markus Armbruster <armbru@redhat.com> Subject: [Qemu-devel] [PATCH v2 3/4] qga: initialize progname with error_set_progname() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: <qemu-devel.nongnu.org> List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe> List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel> List-Post: <mailto:qemu-devel@nongnu.org> List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help> List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=subscribe> Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org |
diff --git a/qga/main.c b/qga/main.c index 9939a2b..0885fc6 100644 --- a/qga/main.c +++ b/qga/main.c @@ -958,6 +958,7 @@ int main(int argc, char **argv) GList *blacklist = NULL; GAState *s; + error_set_progname(argv[0]); module_call_init(MODULE_INIT_QAPI); init_dfl_pathnames();
Calling error_get_progname() in the context of qga can cause segmentation fault because qga doesn't initialize its progname with error_set_progname(). This patch adds the initialization. Currently, the missing call of error_set_progname() doesn't cause any problems because qga doesn't use error_get_progname(). This patch is a proactive action. Cc: Michael Roth <mdroth@linux.vnet.ibm.com> Cc: Markus Armbruster <armbru@redhat.com> Signed-off-by: Hitoshi Mitake <mitake.hitoshi@lab.ntt.co.jp> --- qga/main.c | 1 + 1 file changed, 1 insertion(+)