From patchwork Wed Jan 21 13:18:37 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Armbruster X-Patchwork-Id: 431468 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 471B6140151 for ; Thu, 22 Jan 2015 00:19:11 +1100 (AEDT) Received: from localhost ([::1]:48190 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDvBd-0000DL-3S for incoming@patchwork.ozlabs.org; Wed, 21 Jan 2015 08:19:09 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43957) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDvBH-0008BB-GI for qemu-devel@nongnu.org; Wed, 21 Jan 2015 08:18:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YDvBD-0006oZ-Dk for qemu-devel@nongnu.org; Wed, 21 Jan 2015 08:18:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59769) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDvBD-0006oN-6l for qemu-devel@nongnu.org; Wed, 21 Jan 2015 08:18:43 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0LDIe0W002078 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 21 Jan 2015 08:18:40 -0500 Received: from blackfin.pond.sub.org (ovpn-116-46.ams2.redhat.com [10.36.116.46]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t0LDIcTh029315 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 21 Jan 2015 08:18:39 -0500 Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id BF4B530A4C13; Wed, 21 Jan 2015 14:18:37 +0100 (CET) From: Markus Armbruster To: qemu-devel@nongnu.org Date: Wed, 21 Jan 2015 14:18:37 +0100 Message-Id: <1421846317-7088-1-git-send-email-armbru@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: edgar.iglesias@gmail.com, peter.crosthwaite@xilinx.com Subject: [Qemu-devel] [PATCH] xilinx_ethlite: Clean up after commit 2f991ad X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org The "fall through" added by the commit is clearly intentional. Mark it so. Hushes up Coverity. Signed-off-by: Markus Armbruster Reviewed-by: Peter Crosthwaite --- hw/net/xilinx_ethlite.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/net/xilinx_ethlite.c b/hw/net/xilinx_ethlite.c index 9536f64..ad6b553 100644 --- a/hw/net/xilinx_ethlite.c +++ b/hw/net/xilinx_ethlite.c @@ -146,6 +146,7 @@ eth_write(void *opaque, hwaddr addr, if (!(value & CTRL_S)) { qemu_flush_queued_packets(qemu_get_queue(s->nic)); } + /* fall through */ case R_TX_LEN0: case R_TX_LEN1: case R_TX_GIE0: