From patchwork Mon Jan 19 14:57:09 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jeremy White X-Patchwork-Id: 430559 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 5A7951401F0 for ; Tue, 20 Jan 2015 02:02:23 +1100 (AEDT) Received: from localhost ([::1]:37924 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDDqP-0002BU-HA for incoming@patchwork.ozlabs.org; Mon, 19 Jan 2015 10:02:21 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41250) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDDlZ-0002YP-7M for qemu-devel@nongnu.org; Mon, 19 Jan 2015 09:57:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YDDlW-0006P2-2z for qemu-devel@nongnu.org; Mon, 19 Jan 2015 09:57:21 -0500 Received: from mail.codeweavers.com ([216.251.189.131]:48977) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDDlV-0006NX-VN for qemu-devel@nongnu.org; Mon, 19 Jan 2015 09:57:18 -0500 Received: from jwhite.mn.codeweavers.com ([10.69.137.101] helo=jwhite.mn.codeweavers.com.) by mail.codeweavers.com with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1YDDlP-00011l-R3 for qemu-devel@nongnu.org; Mon, 19 Jan 2015 08:57:11 -0600 From: Jeremy White To: qemu-devel@nongnu.org Date: Mon, 19 Jan 2015 08:57:09 -0600 Message-Id: <1421679429-9047-1-git-send-email-jwhite@codeweavers.com> X-Mailer: git-send-email 1.7.10.4 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 216.251.189.131 Subject: [Qemu-devel] [PATCH] Bug fix: delete the reader entry after queueing an event, not before. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org As far as I can tell, the vreader_remove_reader function is not presently in use anywhere; I have an upcoming patch set that uses it. Signed-off-by: Jeremy White Reviewed-by: Marc-André Lureau --- libcacard/vreader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libcacard/vreader.c b/libcacard/vreader.c index 0315dd8..8b10d6a 100644 --- a/libcacard/vreader.c +++ b/libcacard/vreader.c @@ -529,8 +529,8 @@ vreader_remove_reader(VReader *reader) } vreader_dequeue(vreader_list, current_entry); vreader_list_unlock(); - vreader_list_entry_delete(current_entry); vevent_queue_vevent(vevent_new(VEVENT_READER_REMOVE, reader, NULL)); + vreader_list_entry_delete(current_entry); return VREADER_OK; }