| Message ID | 1421679429-9047-1-git-send-email-jwhite@codeweavers.com |
|---|---|
| State | New |
| Headers | show |
On Mon, Jan 19, 2015 at 3:57 PM, Jeremy White <jwhite@codeweavers.com> wrote: > As far as I can tell, the vreader_remove_reader function is not presently in > use anywhere; I have an upcoming patch set that uses it. > > Signed-off-by: Jeremy White <jwhite@codeweavers.com> > --- > libcacard/vreader.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libcacard/vreader.c b/libcacard/vreader.c > index 0315dd8..8b10d6a 100644 > --- a/libcacard/vreader.c > +++ b/libcacard/vreader.c > @@ -529,8 +529,8 @@ vreader_remove_reader(VReader *reader) > } > vreader_dequeue(vreader_list, current_entry); > vreader_list_unlock(); > - vreader_list_entry_delete(current_entry); > vevent_queue_vevent(vevent_new(VEVENT_READER_REMOVE, reader, NULL)); > + vreader_list_entry_delete(current_entry); > return VREADER_OK; > } > > -- > 1.7.10.4 > > Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
On 19/01/2015 16:42, Marc-André Lureau wrote: > On Mon, Jan 19, 2015 at 3:57 PM, Jeremy White <jwhite@codeweavers.com> wrote: >> As far as I can tell, the vreader_remove_reader function is not presently in >> use anywhere; I have an upcoming patch set that uses it. >> >> Signed-off-by: Jeremy White <jwhite@codeweavers.com> >> --- >> libcacard/vreader.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libcacard/vreader.c b/libcacard/vreader.c >> index 0315dd8..8b10d6a 100644 >> --- a/libcacard/vreader.c >> +++ b/libcacard/vreader.c >> @@ -529,8 +529,8 @@ vreader_remove_reader(VReader *reader) >> } >> vreader_dequeue(vreader_list, current_entry); >> vreader_list_unlock(); >> - vreader_list_entry_delete(current_entry); >> vevent_queue_vevent(vevent_new(VEVENT_READER_REMOVE, reader, NULL)); >> + vreader_list_entry_delete(current_entry); >> return VREADER_OK; >> } >> >> -- >> 1.7.10.4 >> >> > > Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> Gerd, are you maintaining libcacard nowadays? If so, can you add an entry to MAINTAINERS? (And if not, perhaps Marc-André could maintain it...) Paolo
Hi, > > Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> > > Gerd, are you maintaining libcacard nowadays? If so, can you add an > entry to MAINTAINERS? (And if not, perhaps Marc-André could maintain it...) Well, I know next to nothing about libcacard, and I'd very much prefer if someone who knows this better that me maintains it, especially as this is security-sensitive stuff. The best I could do would be "Odd Fixes" mode for libcacard, i.e. collect patches from the list, glace over for obviously broken bits, do a pull request now and then ... cheers, Gerd
On 23/01/2015 14:27, Gerd Hoffmann wrote: > Hi, > >>> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> >> >> Gerd, are you maintaining libcacard nowadays? If so, can you add an >> entry to MAINTAINERS? (And if not, perhaps Marc-André could maintain it...) > > Well, I know next to nothing about libcacard, and I'd very much prefer > if someone who knows this better that me maintains it, especially as > this is security-sensitive stuff. > > The best I could do would be "Odd Fixes" mode for libcacard, i.e. > collect patches from the list, glace over for obviously broken bits, do > a pull request now and then ... Jeremy is obviously doing more than odd fixes though! Paolo
diff --git a/libcacard/vreader.c b/libcacard/vreader.c index 0315dd8..8b10d6a 100644 --- a/libcacard/vreader.c +++ b/libcacard/vreader.c @@ -529,8 +529,8 @@ vreader_remove_reader(VReader *reader) } vreader_dequeue(vreader_list, current_entry); vreader_list_unlock(); - vreader_list_entry_delete(current_entry); vevent_queue_vevent(vevent_new(VEVENT_READER_REMOVE, reader, NULL)); + vreader_list_entry_delete(current_entry); return VREADER_OK; }
As far as I can tell, the vreader_remove_reader function is not presently in use anywhere; I have an upcoming patch set that uses it. Signed-off-by: Jeremy White <jwhite@codeweavers.com> --- libcacard/vreader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)