From patchwork Thu Dec 11 06:25:07 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: lijun X-Patchwork-Id: 419968 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 9A43C1400E7 for ; Thu, 11 Dec 2014 17:32:00 +1100 (AEDT) Received: from localhost ([::1]:49460 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XyxI6-0005fA-Rd for incoming@patchwork.ozlabs.org; Thu, 11 Dec 2014 01:31:58 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32975) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XyxBl-0004Cd-J3 for qemu-devel@nongnu.org; Thu, 11 Dec 2014 01:25:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XyxBc-00043P-IL for qemu-devel@nongnu.org; Thu, 11 Dec 2014 01:25:25 -0500 Received: from mail-pa0-x236.google.com ([2607:f8b0:400e:c03::236]:48788) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XyxBc-00043G-Ax for qemu-devel@nongnu.org; Thu, 11 Dec 2014 01:25:16 -0500 Received: by mail-pa0-f54.google.com with SMTP id fb1so4402574pad.41 for ; Wed, 10 Dec 2014 22:25:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=OF6Jt2F/uwg25x3NAVVB9ZuUazG5FiLIFGpxq88Qtgw=; b=snzo5Lc2utHCWsiXqyevSw3ajQF96b4NrmxiS5Axw1Qum3JuERH7XSAqQ6usP52pIz 8lnPkadho0J8gYEA+IWyDawkoOgjn3RyLvbgzGXKO2Cu8QMy7R03810ZKxDUSx+ZYKIX T1yw3Tu5jfM+ilAgCoDgKq1xZisLJPeKsEcgob30zvU8/Of5zCU7ye+sPErTy4Lt3jcK 6EdSb0qOMgjF66k112nWdpHXwLIp1d0y7aK3AnbOayQopr+4tRncCGA1WVjRCjootUaJ UIG+pPdpFJv3CtpQ1eePo2QVjtEf2etFt8P5ZL7e6VfHTCjrAau63VnlbMTVxDmmLnwJ ExvQ== X-Received: by 10.70.103.37 with SMTP id ft5mr13815262pdb.159.1418279115695; Wed, 10 Dec 2014 22:25:15 -0800 (PST) Received: from localhost ([203.114.244.88]) by mx.google.com with ESMTPSA id n2sm342712pdo.0.2014.12.10.22.25.13 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Dec 2014 22:25:14 -0800 (PST) From: Jun Li To: qemu-devel@nongnu.org Date: Thu, 11 Dec 2014 14:25:07 +0800 Message-Id: <1418279107-10339-1-git-send-email-junmuzi@gmail.com> X-Mailer: git-send-email 1.9.3 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400e:c03::236 Cc: kwolf@redhat.com, famz@redhat.com, juli@redhat.com, stefanha@redhat.com, josh.durgin@inktank.com, Jun Li Subject: [Qemu-devel] [PATCH v2] rbd: print a clear error message when write beyond EOF X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Currently, as rbd driver do not support dynamic growth when write beyond EOF, so just print a clear error message. Signed-off-by: Jun Li --- v2: Just use rbd_aio_write to realize error detection. --- block/rbd.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/block/rbd.c b/block/rbd.c index 5b5a64a..710ee3e 100644 --- a/block/rbd.c +++ b/block/rbd.c @@ -661,6 +661,10 @@ static BlockAIOCB *rbd_start_aio(BlockDriverState *bs, } if (r < 0) { + if (r == -EINVAL && cmd == RBD_AIO_WRITE) { + fprintf(stderr, "Image formats that grow on demand " + "are not supported on rbd.\n"); + } goto failed_completion; }