diff mbox

[2/3] vl.c: simplified machine_set_property

Message ID 1418217570-15517-3-git-send-email-marcel.a@redhat.com
State New
Headers show

Commit Message

Marcel Apfelbaum Dec. 10, 2014, 1:19 p.m. UTC
Refactored the code to re-use object_property_parse.

Signed-off-by: Marcel Apfelbaum <marcel.a@redhat.com>
---
 vl.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

Greg Bellows Dec. 11, 2014, 5:49 p.m. UTC | #1
On 10 December 2014 at 07:19, Marcel Apfelbaum <marcel.a@redhat.com> wrote:

> Refactored the code to re-use object_property_parse.
>
> Signed-off-by: Marcel Apfelbaum <marcel.a@redhat.com>
> ---
>  vl.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index 80d30dd..f9757c3 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2580,7 +2580,6 @@ static int machine_set_property(const char *name,
> const char *value,
>                                  void *opaque)
>  {
>      Object *obj = OBJECT(opaque);
> -    StringInputVisitor *siv;
>      Error *local_err = NULL;
>      char *c, *qom_name;
>
> @@ -2596,9 +2595,7 @@ static int machine_set_property(const char *name,
> const char *value,
>          }
>      }
>
> -    siv = string_input_visitor_new(value);
> -    object_property_set(obj, string_input_get_visitor(siv), qom_name,
> &local_err);
> -    string_input_visitor_cleanup(siv);
> +    object_property_parse(obj, value, qom_name, &local_err);
>      g_free(qom_name);
>
>      if (local_err) {
> --
> 1.9.3
>
>
Reviewed-by: Greg Bellows <greg.bellows@linaro.org>
diff mbox

Patch

diff --git a/vl.c b/vl.c
index 80d30dd..f9757c3 100644
--- a/vl.c
+++ b/vl.c
@@ -2580,7 +2580,6 @@  static int machine_set_property(const char *name, const char *value,
                                 void *opaque)
 {
     Object *obj = OBJECT(opaque);
-    StringInputVisitor *siv;
     Error *local_err = NULL;
     char *c, *qom_name;
 
@@ -2596,9 +2595,7 @@  static int machine_set_property(const char *name, const char *value,
         }
     }
 
-    siv = string_input_visitor_new(value);
-    object_property_set(obj, string_input_get_visitor(siv), qom_name, &local_err);
-    string_input_visitor_cleanup(siv);
+    object_property_parse(obj, value, qom_name, &local_err);
     g_free(qom_name);
 
     if (local_err) {