diff mbox

[PULL,39/73] blockdev: drop unnecessary DriveBackupState field assignment

Message ID 1418207679-32260-40-git-send-email-kwolf@redhat.com
State New
Headers show

Commit Message

Kevin Wolf Dec. 10, 2014, 10:34 a.m. UTC 
From: Stefan Hajnoczi <stefanha@redhat.com>

drive_backup_prepare() assigns DriveBackupState fields to NULL in the
error path.  This is unnecessary because the DriveBackupState is
allocated using g_malloc0() and other functions like
external_snapshot_prepare() already rely on this.

Do not explicitly assign fields to NULL so that the error path is
concise and does not require modification when fields are added to
DriveBackupState.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Message-id: 1416566940-4430-3-git-send-email-stefanha@redhat.com
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 blockdev.c | 2 --
 1 file changed, 2 deletions(-)
diff mbox

Patch

diff --git a/blockdev.c b/blockdev.c
index 490f698..b58ce30 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -1489,8 +1489,6 @@  static void drive_backup_prepare(BlkTransactionState *common, Error **errp)
                      &local_err);
     if (local_err) {
         error_propagate(errp, local_err);
-        state->bs = NULL;
-        state->job = NULL;
         return;
     }