From patchwork Thu Nov 13 15:40:22 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 410472 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 9A1831400D5 for ; Fri, 14 Nov 2014 02:46:52 +1100 (AEDT) Received: from localhost ([::1]:60618 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xowbi-0006je-S5 for incoming@patchwork.ozlabs.org; Thu, 13 Nov 2014 10:46:50 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37357) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XowW2-0004h6-RU for qemu-devel@nongnu.org; Thu, 13 Nov 2014 10:41:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XowVt-0007mY-MY for qemu-devel@nongnu.org; Thu, 13 Nov 2014 10:40:58 -0500 Received: from mail-wg0-x233.google.com ([2a00:1450:400c:c00::233]:37468) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XowVt-0007mQ-GR for qemu-devel@nongnu.org; Thu, 13 Nov 2014 10:40:49 -0500 Received: by mail-wg0-f51.google.com with SMTP id l18so17551974wgh.10 for ; Thu, 13 Nov 2014 07:40:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=vRiMNVfgK52G9nbdO0GDApHmq/+h/cN+65123A9oGc0=; b=CWBDBQGL2f9CKDYv+dbzEYYTIWFq9kqrrP5HI9cJzYMCeYDJs6rBen8hSTkQSjatT0 fBM4sPVAsEm+oZB5xfopiiPpnsvgXbPcKY5zIg/3pynJY5amo1gslTgU6JPbC3pSDYOg 80k0R9gdH+LHBZAWuCDOqu/jNpfERUeP4Y2mNt7WaSndfnfAgh1n2M+V/hCtjBFMj8bR KlsEo2EJDeOsAqADlOf6lUzsnnzIAB5RF5hiYKxQdMjybQtFqKVKkYeMOUk9R6LbV6Ko 9P4xGdogI0MF0k8Swq+nD2NNQz4AiVg9fU3i9zitzxCjwYs8j5oKlmPJNKrFhEIMqV8x Srlg== X-Received: by 10.181.13.139 with SMTP id ey11mr4945715wid.14.1415893248865; Thu, 13 Nov 2014 07:40:48 -0800 (PST) Received: from playground.station (net-37-117-142-149.cust.vodafonedsl.it. [37.117.142.149]) by mx.google.com with ESMTPSA id u13sm26168441wiv.10.2014.11.13.07.40.47 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Nov 2014 07:40:48 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Thu, 13 Nov 2014 16:40:22 +0100 Message-Id: <1415893228-25823-8-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1415893228-25823-1-git-send-email-pbonzini@redhat.com> References: <1415893228-25823-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c00::233 Cc: Fam Zheng Subject: [Qemu-devel] [PULL 07/13] virtio-scsi: Fix comment for VirtIOSCSIReq X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Fam Zheng The cdb is not zeroed by virtio_scsi_init_req, so fix the misleading comment. Suggested-by: Markus Armbruster Signed-off-by: Fam Zheng Signed-off-by: Paolo Bonzini --- include/hw/virtio/virtio-scsi.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/hw/virtio/virtio-scsi.h b/include/hw/virtio/virtio-scsi.h index 9e1a49c..bf17cc9 100644 --- a/include/hw/virtio/virtio-scsi.h +++ b/include/hw/virtio/virtio-scsi.h @@ -209,7 +209,8 @@ typedef struct VirtIOSCSIReq { /* Note: * - fields before elem are initialized by virtio_scsi_init_req; * - elem is uninitialized at the time of allocation. - * - fields after elem are zeroed by virtio_scsi_init_req. + * - fields after elem (except the ending cdb[]) are zeroed by + * virtio_scsi_init_req. * */ VirtQueueElement elem;