From patchwork Wed Nov 5 08:09:52 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeokYeon Hwang X-Patchwork-Id: 406897 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3687214003E for ; Wed, 5 Nov 2014 19:10:56 +1100 (AEDT) Received: from localhost ([::1]:44920 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xlvg5-000868-Ib for incoming@patchwork.ozlabs.org; Wed, 05 Nov 2014 03:10:53 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35766) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlvfN-0007HK-6u for qemu-devel@nongnu.org; Wed, 05 Nov 2014 03:10:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XlvfF-0003ap-SE for qemu-devel@nongnu.org; Wed, 05 Nov 2014 03:10:09 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:23446) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlvfF-0003Y0-Id for qemu-devel@nongnu.org; Wed, 05 Nov 2014 03:10:01 -0500 Received: from epcpsbgm2.samsung.com (epcpsbgm2 [203.254.230.27]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NEK00FND40NAL90@mailout3.samsung.com> for qemu-devel@nongnu.org; Wed, 05 Nov 2014 17:09:59 +0900 (KST) X-AuditID: cbfee61b-f79d76d0000024d6-ba-5459db57ac48 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 02.EC.09430.75BD9545; Wed, 05 Nov 2014 17:09:59 +0900 (KST) Received: from localhost.localdomain ([182.198.1.3]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0NEK00IFF40M1UE0@mmp1.samsung.com>; Wed, 05 Nov 2014 17:09:58 +0900 (KST) From: SeokYeon Hwang To: qemu-devel@nongnu.org Date: Wed, 05 Nov 2014 17:09:52 +0900 Message-id: <1415174992-13246-1-git-send-email-syeon.hwang@samsung.com> X-Mailer: git-send-email 2.1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrLJMWRmVeSWpSXmKPExsVy+t9jAd3w25EhBi+XcljMX3ufxWLeLWWL Scemslkc793BYnFj/Wk2B1aPnbPusns8ubaZyeP9vqtsHn1bVjEGsERx2aSk5mSWpRbp2yVw Zeye3ctS8IOtonH5dfYGxn2sXYycHBICJhKnnyxkgbDFJC7cW8/WxcjFISSwiFHiYtcqJgin hUmi/X0HWAebgJ7EhmUHGEFsEQFJid9dp5lBbGaBXIkVM16yg9jCAtESzQungU1lEVCVWL7j LpjNK+AucW/jZSaIbXISG3b/Z5zAyL2AkWEVo2hqQXJBcVJ6rpFecWJucWleul5yfu4mRnAg PJPewbiqweIQowAHoxIPr0FuZIgQa2JZcWXuIUYJDmYlEV7OS0Ah3pTEyqrUovz4otKc1OJD jNIcLErivAdbrQOFBNITS1KzU1MLUotgskwcnFINjJLhi87PEE75fWbpQ/6pdhPnbVReZNS5 3YcxZV4Ko6/WyZfNPzS9N6mYLuf18BQT49tjU2BeJZab8Pn1gsWHH7rbCFy6q/mqcZ2wz5KX bq3PZ7a+4Tu4u/bhO6W359qmmhc2dUr9vt18J0hzzr5da24sjky4apX2+f+fxZG992I2nEmc Efl/brASS3FGoqEWc1FxIgBpIomUAAIAAA== X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 203.254.224.33 Cc: SeokYeon Hwang , paolo.bonzini@gmail.com, armbru@redhat.com, mreitz@redhat.com Subject: [Qemu-devel] [PATCH] error: fixed error_set_errno() to deal with a negative type of os_error. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Negative type of errno like -ERRNO is used a lot by developers. Therefore, error_set_errno() is modified to deal with a negative type of os_error. (Negative type is used at pcie_cap_slot_hotplug_common() in hw/pci/pcie.c) Signed-off-by: SeokYeon Hwang Reviewed-by: Max Reitz --- util/error.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/error.c b/util/error.c index 2ace0d8..5db00c9 100644 --- a/util/error.c +++ b/util/error.c @@ -68,7 +68,7 @@ void error_set_errno(Error **errp, int os_errno, ErrorClass err_class, va_start(ap, fmt); msg1 = g_strdup_vprintf(fmt, ap); if (os_errno != 0) { - err->msg = g_strdup_printf("%s: %s", msg1, strerror(os_errno)); + err->msg = g_strdup_printf("%s: %s", msg1, strerror(abs(os_errno))); g_free(msg1); } else { err->msg = msg1;