diff mbox

[v4,23/23] block: Make device model's references to BlockBackend strong

Message ID 1412105144-532-24-git-send-email-armbru@redhat.com
State New
Headers show

Commit Message

Markus Armbruster Sept. 30, 2014, 7:25 p.m. UTC
Doesn't make a difference just yet, but it's the right thing to do.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Benoît Canet <benoit.canet@nodalink.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
---
 block/block-backend.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Max Reitz Oct. 1, 2014, 5:22 p.m. UTC | #1
On 30.09.2014 21:25, Markus Armbruster wrote:
> Doesn't make a difference just yet, but it's the right thing to do.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> Reviewed-by: Benoît Canet <benoit.canet@nodalink.com>
> Reviewed-by: Kevin Wolf <kwolf@redhat.com>
> ---
>   block/block-backend.c | 2 ++
>   1 file changed, 2 insertions(+)

Reviewed-by: Max Reitz <mreitz@redhat.com>
diff mbox

Patch

diff --git a/block/block-backend.c b/block/block-backend.c
index bdcbac6..d0692b1 100644
--- a/block/block-backend.c
+++ b/block/block-backend.c
@@ -257,6 +257,7 @@  int blk_attach_dev(BlockBackend *blk, void *dev)
     if (blk->dev) {
         return -EBUSY;
     }
+    blk_ref(blk);
     blk->dev = dev;
     bdrv_iostatus_reset(blk->bs);
 
@@ -290,6 +291,7 @@  void blk_detach_dev(BlockBackend *blk, void *dev)
     blk->dev_opaque = NULL;
     bdrv_set_guest_block_size(blk->bs, 512);
     qemu_coroutine_adjust_pool_size(-COROUTINE_POOL_RESERVATION);
+    blk_unref(blk);
 }
 
 /*