From patchwork Thu Sep 18 06:33:56 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gerd Hoffmann X-Patchwork-Id: 390648 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 9A2581401DC for ; Thu, 18 Sep 2014 16:37:14 +1000 (EST) Received: from localhost ([::1]:48736 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUVL6-00032I-Ol for incoming@patchwork.ozlabs.org; Thu, 18 Sep 2014 02:37:12 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47911) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUVKW-0002D3-Fd for qemu-devel@nongnu.org; Thu, 18 Sep 2014 02:36:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XUVKP-0000sV-Br for qemu-devel@nongnu.org; Thu, 18 Sep 2014 02:36:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17502) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUVKP-0000ry-27 for qemu-devel@nongnu.org; Thu, 18 Sep 2014 02:36:29 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8I6Y1mH031294 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 18 Sep 2014 02:34:01 -0400 Received: from nilsson.home.kraxel.org (ovpn-116-127.ams2.redhat.com [10.36.116.127]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s8I6Y0EY030163; Thu, 18 Sep 2014 02:34:00 -0400 Received: by nilsson.home.kraxel.org (Postfix, from userid 500) id 85A4D8314D; Thu, 18 Sep 2014 08:33:59 +0200 (CEST) From: Gerd Hoffmann To: qemu-devel@nongnu.org Date: Thu, 18 Sep 2014 08:33:56 +0200 Message-Id: <1411022036-17668-3-git-send-email-kraxel@redhat.com> In-Reply-To: <1411022036-17668-1-git-send-email-kraxel@redhat.com> References: <1411022036-17668-1-git-send-email-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: Markus Armbruster , Anthony Liguori , Gerd Hoffmann Subject: [Qemu-devel] [PULL 2/2] vnc-tls: Clean up dead store in vnc_set_x509_credential() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Markus Armbruster Signed-off-by: Markus Armbruster Signed-off-by: Gerd Hoffmann --- ui/vnc-tls.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/ui/vnc-tls.c b/ui/vnc-tls.c index 6392326..0f59f9b 100644 --- a/ui/vnc-tls.c +++ b/ui/vnc-tls.c @@ -444,8 +444,6 @@ static int vnc_set_x509_credential(VncDisplay *vd, struct stat sb; g_free(*cred); - *cred = NULL; - *cred = g_malloc(strlen(certdir) + strlen(filename) + 2); strcpy(*cred, certdir);