From patchwork Mon Sep 15 15:03:39 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 389407 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49BA9140142 for ; Tue, 16 Sep 2014 01:10:14 +1000 (EST) Received: from localhost ([::1]:60466 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTXuu-0000w6-23 for incoming@patchwork.ozlabs.org; Mon, 15 Sep 2014 11:10:12 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52575) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTXpH-0000B6-Lc for qemu-devel@nongnu.org; Mon, 15 Sep 2014 11:04:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XTXp8-00089V-Kb for qemu-devel@nongnu.org; Mon, 15 Sep 2014 11:04:23 -0400 Received: from mail-wi0-x22f.google.com ([2a00:1450:400c:c05::22f]:52398) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTXp8-00085w-2m for qemu-devel@nongnu.org; Mon, 15 Sep 2014 11:04:14 -0400 Received: by mail-wi0-f175.google.com with SMTP id cc10so4426474wib.8 for ; Mon, 15 Sep 2014 08:04:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=CE1FCUfs+HLTuAoSddXJe2032Wpx2mCJBs5NSgpWUBY=; b=ntjOpP3HVbrLTUqjnLFFs+EpmGJZXKDIqQShfTdBoERwuTzc49kmlaYdPee2c15pcU XFauUEALUnVTzPocF+lIbshMnpJ3TN0SfhXfo10jerkvBRbk+XVFZxWdUdvgTphWs5eC rwbjDQnnnwDWqJa+EDWFnLuzvjYCpx6kvfq3PdxIQ+CIeelEdbS6hafDULZs6ZyBUEtt ri68sT+yxxMXcK+NlSRYzgf58TzW2dAd2auFggGmv4UqixWc3P5/Y+0fOI/Q+S69jkMv h2QeXkZyuB621y43r0+s81I/De1vhNrqGoh10850xHiKe2/dUchEMgLuVkrMIGvCm87g Ck3w== X-Received: by 10.194.190.69 with SMTP id go5mr31757388wjc.56.1410793453134; Mon, 15 Sep 2014 08:04:13 -0700 (PDT) Received: from playground.station (net-37-116-212-135.cust.vodafonedsl.it. [37.116.212.135]) by mx.google.com with ESMTPSA id y5sm15069460wje.32.2014.09.15.08.04.11 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 Sep 2014 08:04:11 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Mon, 15 Sep 2014 17:03:39 +0200 Message-Id: <1410793421-6453-13-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1410793421-6453-1-git-send-email-pbonzini@redhat.com> References: <1410793421-6453-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c05::22f Cc: tommusta@gmail.com, agraf@suse.de Subject: [Qemu-devel] [PATCH 12/14] ppc: use movcond to implement evsel X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This simplifies the code and avoids basic block splitting. Signed-off-by: Paolo Bonzini --- v1->v2: new, noticed during re-review target-ppc/translate.c | 27 +++++++++++---------------- 1 file changed, 11 insertions(+), 16 deletions(-) diff --git a/target-ppc/translate.c b/target-ppc/translate.c index d8c9240..cdd5187 100644 --- a/target-ppc/translate.c +++ b/target-ppc/translate.c @@ -8798,24 +8798,19 @@ static inline void gen_evsplatfi(DisasContext *ctx) static inline void gen_evsel(DisasContext *ctx) { - int l1 = gen_new_label(); - int l2 = gen_new_label(); - int l3 = gen_new_label(); - int l4 = gen_new_label(); + TCGv tmp = tcg_temp_new(); + TCGv zero = tcg_const_tl(0); - tcg_gen_brcondi_i32(TCG_COND_EQ, cpu_cr[(ctx->opcode & 0x07) * 4], 0, l1); - tcg_gen_mov_tl(cpu_gprh[rD(ctx->opcode)], cpu_gprh[rA(ctx->opcode)]); - tcg_gen_br(l2); - gen_set_label(l1); - tcg_gen_mov_tl(cpu_gprh[rD(ctx->opcode)], cpu_gprh[rB(ctx->opcode)]); - gen_set_label(l2); + tcg_gen_extu_i32_tl(tmp, cpu_cr[(ctx->opcode & 0x07) * 4 + CRF_CH]); + tcg_gen_movcond_tl(TCG_COND_NE, cpu_gprh[rD(ctx->opcode)], tmp, zero, + cpu_gprh[rA(ctx->opcode)], cpu_gprh[rB(ctx->opcode)]); - tcg_gen_brcondi_i32(TCG_COND_EQ, cpu_cr[(ctx->opcode & 0x07) * 4 + 1], 0, l3); - tcg_gen_mov_tl(cpu_gpr[rD(ctx->opcode)], cpu_gpr[rA(ctx->opcode)]); - tcg_gen_br(l4); - gen_set_label(l3); - tcg_gen_mov_tl(cpu_gpr[rD(ctx->opcode)], cpu_gpr[rB(ctx->opcode)]); - gen_set_label(l4); + tcg_gen_extu_i32_tl(tmp, cpu_cr[(ctx->opcode & 0x07) * 4 + CRF_CL]); + tcg_gen_movcond_tl(TCG_COND_NE, cpu_gpr[rD(ctx->opcode)], tmp, zero, + cpu_gpr[rA(ctx->opcode)], cpu_gpr[rB(ctx->opcode)]); + + tcg_temp_free(zero); + tcg_temp_free(tmp); } static void gen_evsel0(DisasContext *ctx)