From patchwork Fri Sep 5 20:07:41 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Lieven X-Patchwork-Id: 386513 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id AF7D0140174 for ; Sat, 6 Sep 2014 06:08:37 +1000 (EST) Received: from localhost ([::1]:60011 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPzoA-0007vX-BQ for incoming@patchwork.ozlabs.org; Fri, 05 Sep 2014 16:08:34 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33916) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPznn-0007bb-NM for qemu-devel@nongnu.org; Fri, 05 Sep 2014 16:08:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XPznh-0002ox-Rh for qemu-devel@nongnu.org; Fri, 05 Sep 2014 16:08:11 -0400 Received: from mx-v6.kamp.de ([2a02:248:0:51::16]:35705 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPznh-0002nz-Gi for qemu-devel@nongnu.org; Fri, 05 Sep 2014 16:08:05 -0400 Received: (qmail 18707 invoked by uid 89); 5 Sep 2014 20:08:03 -0000 Received: from [82.141.1.145] by client-16-kamp (envelope-from , uid 89) with qmail-scanner-2010/03/19-MF (clamdscan: 0.98.4/19339. hbedv: 8.3.24.22/7.11.170.240. spamassassin: 3.4.0. Clear:RC:1(82.141.1.145):SA:0(-1.5/4.0):. Processed in 0.820725 secs); 05 Sep 2014 20:08:03 -0000 Received: from ns.kamp-intra.net (HELO dns.kamp-intra.net) ([82.141.1.145]) by mx01.kamp.de with SMTP; 5 Sep 2014 20:08:02 -0000 X-GL_Whitelist: yes Received: from lieven-pc.kamp-intra.net (lieven-pc.kamp-intra.net [172.21.12.60]) by dns.kamp-intra.net (Postfix) with ESMTP id 2F55520683; Fri, 5 Sep 2014 22:07:42 +0200 (CEST) Received: by lieven-pc.kamp-intra.net (Postfix, from userid 1000) id 292555FCEC; Fri, 5 Sep 2014 22:07:42 +0200 (CEST) From: Peter Lieven To: qemu-devel@nongnu.org Date: Fri, 5 Sep 2014 22:07:41 +0200 Message-Id: <1409947661-19614-1-git-send-email-pl@kamp.de> X-Mailer: git-send-email 1.7.9.5 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a02:248:0:51::16 Cc: peter.maydell@linaro.org, Peter Lieven , kraxel@redhat.com Subject: [Qemu-devel] [PATCHv2] ui/vnc: set TCP_NODELAY X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org we currently have the Nagle algorithm enabled for all outgoing VNC updates. This may delay sensitive updates as mouse movements or typing in the console. As we currently prepare all data in a buffer and then send as much as we can disabling the Nagle algorithm should not cause big trouble. Well established VNC servers like TightVNC set TCP_NODELAY as well. A regular framebuffer update request generates exactly one framebuffer update which should be pushed out as fast as possible. Signed-off-by: Peter Lieven --- v1->v2: use socket_set_nodelay (Peter) ui/vnc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ui/vnc.c b/ui/vnc.c index f8d9b7d..0fe6eff 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -2914,6 +2914,7 @@ static void vnc_listen_read(void *opaque, bool websocket) } if (csock != -1) { + socket_set_nodelay(csock); vnc_connect(vs, csock, false, websocket); } }