From patchwork Thu Aug 28 14:13:21 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 383865 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id D500214011E for ; Fri, 29 Aug 2014 00:19:50 +1000 (EST) Received: from localhost ([::1]:36852 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XN0YG-0001Lc-Rh for incoming@patchwork.ozlabs.org; Thu, 28 Aug 2014 10:19:48 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59495) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XN0SP-0007qH-57 for qemu-devel@nongnu.org; Thu, 28 Aug 2014 10:13:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XN0SJ-0002r4-O2 for qemu-devel@nongnu.org; Thu, 28 Aug 2014 10:13:45 -0400 Received: from mail-wi0-x22c.google.com ([2a00:1450:400c:c05::22c]:60758) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XN0SJ-0002qv-H3 for qemu-devel@nongnu.org; Thu, 28 Aug 2014 10:13:39 -0400 Received: by mail-wi0-f172.google.com with SMTP id n3so7554757wiv.17 for ; Thu, 28 Aug 2014 07:13:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=mT6IWY9dMjnAtUgQvfyax0F68xghC4D2FUWVBWlWa10=; b=iNUvxLkcLRPbinz+Ka3xJqKfTj/cbrL6LkRy542I+6bVOL7NLUZ3wMc51GbkqeEqTP A48/dudnNH0YLLyHB853wZbnhDggOx7g33GitbOIhp4aijA8D5H5F4Czkfj5T6GJrFMb lwiEF/RDK5Dy9580yP4q0KnEF88bOHm4Sgr7JAFfscH+8gkDcrEBXcKkq6uq5ELj8wkt u1wKZqYvWlGXA1QqnmveRUe682Po6Cgpz6JzbJBhq7nB+40yWoEVDb8sUZEUHSL9Wm+/ Mf1Wbm1aBnZEJOKvdkVFNHaeMUjdgYDm5/tZlEzT3F/UipxYPBh+rPro5wqKwGGq8lfn r5Iw== X-Received: by 10.194.23.8 with SMTP id i8mr5513389wjf.104.1409235217997; Thu, 28 Aug 2014 07:13:37 -0700 (PDT) Received: from playground.station (net-37-116-212-108.cust.vodafonedsl.it. [37.116.212.108]) by mx.google.com with ESMTPSA id mz16sm15216059wic.13.2014.08.28.07.13.36 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Aug 2014 07:13:37 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Thu, 28 Aug 2014 16:13:21 +0200 Message-Id: <1409235205-21376-5-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1409235205-21376-1-git-send-email-pbonzini@redhat.com> References: <1409235205-21376-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c05::22c Cc: Gonglei Subject: [Qemu-devel] [PULL 4/8] scsi-generic: remove superfluous DPRINTF avoid to break compiling X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Gonglei variables lun and tag had been eliminated, break compiling when enable debug switch. Meanwhile traces provide the same information with this DPRINTF, so remove it. Signed-off-by: Gonglei Signed-off-by: Paolo Bonzini --- hw/scsi/scsi-generic.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/scsi/scsi-generic.c b/hw/scsi/scsi-generic.c index 3ebe4a6..20587b4 100644 --- a/hw/scsi/scsi-generic.c +++ b/hw/scsi/scsi-generic.c @@ -303,9 +303,6 @@ static int32_t scsi_send_command(SCSIRequest *req, uint8_t *cmd) SCSIDevice *s = r->req.dev; int ret; - DPRINTF("Command: lun=%d tag=0x%x len %zd data=0x%02x", lun, tag, - r->req.cmd.xfer, cmd[0]); - #ifdef DEBUG_SCSI { int i;