| Message ID | 1408626189-6220-1-git-send-email-arei.gonglei@huawei.com |
|---|---|
| State | New |
| Headers | show |
Hi, Cc'ing qemu-trivial. Please consider receiving, thanks. Best regards, -Gonglei > -----Original Message----- > From: Gonglei (Arei) > Sent: Thursday, August 21, 2014 9:03 PM > To: qemu-devel@nongnu.org > Cc: lcapitulino@redhat.com; Huangweidong (C); peter.crosthwaite@xilinx.com; > Gonglei (Arei) > Subject: [PATCH v2] monitor: fix debug print compiling error > > From: Gonglei <arei.gonglei@huawei.com> > > error: 'i' undeclared (first use in this function) > > Signed-off-by: Gonglei <arei.gonglei@huawei.com> > --- > v2: > avoid to mix code and declarations, add a pair of {}, thanks Peter. > --- > monitor.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/monitor.c b/monitor.c > index 34cee74..667efb7 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -4747,8 +4747,11 @@ static void monitor_find_completion(void *opaque, > return; > } > #ifdef DEBUG_COMPLETION > - for (i = 0; i < nb_args; i++) { > - monitor_printf(mon, "arg%d = '%s'\n", i, args[i]); > + { > + int i; > + for (i = 0; i < nb_args; i++) { > + monitor_printf(mon, "arg%d = '%s'\n", i, args[i]); > + } > } > #endif > > -- > 1.7.12.4 >
On Thu, 21 Aug 2014 21:03:09 +0800 <arei.gonglei@huawei.com> wrote: > From: Gonglei <arei.gonglei@huawei.com> > > error: 'i' undeclared (first use in this function) > > Signed-off-by: Gonglei <arei.gonglei@huawei.com> Applied to the qmp branch, thanks. > --- > v2: > avoid to mix code and declarations, add a pair of {}, thanks Peter. > --- > monitor.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/monitor.c b/monitor.c > index 34cee74..667efb7 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -4747,8 +4747,11 @@ static void monitor_find_completion(void *opaque, > return; > } > #ifdef DEBUG_COMPLETION > - for (i = 0; i < nb_args; i++) { > - monitor_printf(mon, "arg%d = '%s'\n", i, args[i]); > + { > + int i; > + for (i = 0; i < nb_args; i++) { > + monitor_printf(mon, "arg%d = '%s'\n", i, args[i]); > + } > } > #endif >
diff --git a/monitor.c b/monitor.c index 34cee74..667efb7 100644 --- a/monitor.c +++ b/monitor.c @@ -4747,8 +4747,11 @@ static void monitor_find_completion(void *opaque, return; } #ifdef DEBUG_COMPLETION - for (i = 0; i < nb_args; i++) { - monitor_printf(mon, "arg%d = '%s'\n", i, args[i]); + { + int i; + for (i = 0; i < nb_args; i++) { + monitor_printf(mon, "arg%d = '%s'\n", i, args[i]); + } } #endif