diff mbox

[v7] tcg: dump op count into qemu log

Message ID 1408348688-10260-1-git-send-email-zhang.zhanghailiang@huawei.com
State New
Headers show

Commit Message

Zhanghailiang Aug. 18, 2014, 7:58 a.m. UTC 
fopen() may fail and it does not check its return vaule here,
it is better to dump op count to the normal log file.

Signed-off-by: Li Liu <john.liuli@huawei.com>
Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
---
 tcg/tcg.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

Michael Tokarev Aug. 18, 2014, 11:32 a.m. UTC | #1 
18.08.2014 11:58, zhanghailiang wrote:
> fopen() may fail and it does not check its return vaule here,
> it is better to dump op count to the normal log file.

Applied to -trivial, thank you!

/mjt
diff mbox

Patch

diff --git a/tcg/tcg.c b/tcg/tcg.c
index c068990..7a84b87 100644
--- a/tcg/tcg.c
+++ b/tcg/tcg.c
@@ -2404,12 +2404,10 @@  static int64_t tcg_table_op_count[NB_OPS];
 static void dump_op_count(void)
 {
     int i;
-    FILE *f;
-    f = fopen("/tmp/op.log", "w");
+
     for(i = INDEX_op_end; i < NB_OPS; i++) {
-        fprintf(f, "%s %" PRId64 "\n", tcg_op_defs[i].name, tcg_table_op_count[i]);
+        qemu_log("%s %" PRId64 "\n", tcg_op_defs[i].name, tcg_table_op_count[i]);
     }
-    fclose(f);
 }
 #endif