From patchwork Mon Jul 7 18:18:05 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Snow X-Patchwork-Id: 367675 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3936F1400B8 for ; Tue, 8 Jul 2014 04:27:23 +1000 (EST) Received: from localhost ([::1]:52262 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4DdJ-0005KJ-4X for incoming@patchwork.ozlabs.org; Mon, 07 Jul 2014 14:27:21 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38978) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4DV8-0003Q6-17 for qemu-devel@nongnu.org; Mon, 07 Jul 2014 14:19:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X4DUy-0004II-Mi for qemu-devel@nongnu.org; Mon, 07 Jul 2014 14:18:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58257) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4DUy-0004IA-CK for qemu-devel@nongnu.org; Mon, 07 Jul 2014 14:18:44 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s67IIgDt031109 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 7 Jul 2014 14:18:43 -0400 Received: from dhcp-17-12.bos.redhat.com ([10.18.17.124]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s67IIMNI020937; Mon, 7 Jul 2014 14:18:41 -0400 From: John Snow To: qemu-devel@nongnu.org Date: Mon, 7 Jul 2014 14:18:05 -0400 Message-Id: <1404757089-4836-25-git-send-email-jsnow@redhat.com> In-Reply-To: <1404757089-4836-1-git-send-email-jsnow@redhat.com> References: <1404757089-4836-1-git-send-email-jsnow@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: pbonzini@redhat.com, John Snow , stefanha@redhat.com, mst@redhat.com Subject: [Qemu-devel] [PATCH 24/28] ahci: Add test_pci_spec to ahci-test. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Adds a specification adherence test for AHCI where the boot-up values for the PCI configuration space are compared against the AHCI 1.3 specification. This test does not itself attempt to engage the device. Signed-off-by: John Snow --- tests/ahci-test.c | 271 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 271 insertions(+) diff --git a/tests/ahci-test.c b/tests/ahci-test.c index b3ed85f..e0a8f34 100644 --- a/tests/ahci-test.c +++ b/tests/ahci-test.c @@ -43,6 +43,11 @@ /*** Supplementary PCI Config Space IDs & Masks ***/ #define PCI_DEVICE_ID_INTEL_Q35_AHCI (0x2922) +#define PCI_MSI_FLAGS_RESERVED (0xFF00) +#define PCI_PM_CTRL_RESERVED (0xFC) +#define PCI_BCC(REG32) ((REG32) >> 24) +#define PCI_PI(REG32) (((REG32) >> 8) & 0xFF) +#define PCI_SCC(REG32) (((REG32) >> 16) & 0xFF) /* To help make it clear that the HBA is not a pointer to local memory. */ typedef void HBA; @@ -52,9 +57,22 @@ static QGuestAllocator *guest_malloc; static QPCIBus *pcibus; static char tmp_path[] = "/tmp/qtest.XXXXXX"; +/*** Macro Utilities ***/ +#define bitany(data, mask) (((data) & (mask)) != 0) +#define bitset(data, mask) (((data) & (mask)) == (mask)) +#define bitclr(data, mask) (((data) & (mask)) == 0) +#define assert_bit_set(data, mask) g_assert_cmphex((data) & (mask), ==, (mask)) +#define assert_bit_clear(data, mask) g_assert_cmphex((data) & (mask), ==, 0) + /*** Function Declarations ***/ static QPCIDevice *get_ahci_device(void); static void free_ahci_device(QPCIDevice *dev); +static void ahci_test_pci_spec(QPCIDevice *ahci); +static void ahci_test_pci_caps(QPCIDevice *ahci, uint16_t header, + uint8_t offset); +static void ahci_test_satacap(QPCIDevice *ahci, uint8_t offset); +static void ahci_test_msicap(QPCIDevice *ahci, uint8_t offset); +static void ahci_test_pmcap(QPCIDevice *ahci, uint8_t offset); /*** Utilities ***/ @@ -156,6 +174,246 @@ static void ahci_shutdown(QPCIDevice *ahci) qtest_shutdown(); } +/*** Specification Adherence Tests ***/ + +/** + * Implementation for test_pci_spec. Ensures PCI configuration space is sane. + */ +static void ahci_test_pci_spec(QPCIDevice *ahci) +{ + uint8_t datab; + uint16_t data; + uint32_t datal; + + /* Most of these bits should start cleared until we turn them on. */ + data = qpci_config_readw(ahci, PCI_COMMAND); + assert_bit_clear(data, PCI_COMMAND_MEMORY); + assert_bit_clear(data, PCI_COMMAND_MASTER); + assert_bit_clear(data, PCI_COMMAND_SPECIAL); /* Reserved */ + assert_bit_clear(data, PCI_COMMAND_VGA_PALETTE); /* Reserved */ + assert_bit_clear(data, PCI_COMMAND_PARITY); + assert_bit_clear(data, PCI_COMMAND_WAIT); /* Reserved */ + assert_bit_clear(data, PCI_COMMAND_SERR); + assert_bit_clear(data, PCI_COMMAND_FAST_BACK); + assert_bit_clear(data, PCI_COMMAND_INTX_DISABLE); + assert_bit_clear(data, 0xF800); /* Reserved */ + + data = qpci_config_readw(ahci, PCI_STATUS); + assert_bit_clear(data, 0x01 | 0x02 | 0x04); /* Reserved */ + assert_bit_clear(data, PCI_STATUS_INTERRUPT); + assert_bit_set(data, PCI_STATUS_CAP_LIST); /* must be set */ + assert_bit_clear(data, PCI_STATUS_UDF); /* Reserved */ + assert_bit_clear(data, PCI_STATUS_PARITY); + assert_bit_clear(data, PCI_STATUS_SIG_TARGET_ABORT); + assert_bit_clear(data, PCI_STATUS_REC_TARGET_ABORT); + assert_bit_clear(data, PCI_STATUS_REC_MASTER_ABORT); + assert_bit_clear(data, PCI_STATUS_SIG_SYSTEM_ERROR); + assert_bit_clear(data, PCI_STATUS_DETECTED_PARITY); + + /* RID occupies the low byte, CCs occupy the high three. */ + datal = qpci_config_readl(ahci, PCI_CLASS_REVISION); +#ifdef AHCI_13_STRICT + /* AHCI 1.3 specifies that at-boot, the RID should reset to 0x00. */ + assert_bit_clear(datal, 0xFF); +#else + if (datal & 0xFF) { + g_test_message("WARN: Revision ID (%u) != 0", datal & 0xFF); + } +#endif + + /* BCC *must* equal 0x01. */ + g_assert(PCI_BCC(datal) == 0x01); + if (PCI_SCC(datal) == 0x01) { + /* IDE */ + assert_bit_set(0x80000000, datal); + assert_bit_clear(0x60000000, datal); + } else if (PCI_SCC(datal) == 0x04) { + /* RAID */ + g_assert(PCI_PI(datal) == 0); + } else if (PCI_SCC(datal) == 0x06) { + /* AHCI */ + g_assert(PCI_PI(datal) == 0x01); + } else { + g_assert_not_reached(); + } + + datab = qpci_config_readb(ahci, PCI_CACHE_LINE_SIZE); + g_assert(datab == 0); + + datab = qpci_config_readb(ahci, PCI_LATENCY_TIMER); + g_assert(datab == 0); + + /* Only the bottom 7 bits must be off. */ + datab = qpci_config_readb(ahci, PCI_HEADER_TYPE); + assert_bit_clear(datab, 0x7F); + + /* BIST is optional, but the low 7 bits must always start off regardless. */ + datab = qpci_config_readb(ahci, PCI_BIST); + assert_bit_clear(datab, 0x7F); + + /* BARS 0-4 do not have a boot spec, but ABAR/BAR5 must be clean. */ + datal = qpci_config_readl(ahci, PCI_BASE_ADDRESS_5); + g_assert(datal == 0); + + qpci_config_writel(ahci, PCI_BASE_ADDRESS_5, 0xFFFFFFFF); + datal = qpci_config_readl(ahci, PCI_BASE_ADDRESS_5); + /* ABAR must be 32-bit, memory mapped, non-prefetchable and + * must be >= 512 bytes. To that end, bits 0-8 must be off. */ + assert_bit_clear(datal, 0xFF); + + /* Capability list MUST be present, */ + datal = qpci_config_readl(ahci, PCI_CAPABILITY_LIST); + /* But these bits are reserved. */ + assert_bit_clear(datal, ~0xFF); + g_assert_cmphex(datal, !=, 0); + + /* Check specification adherence for capability extenstions. */ + data = qpci_config_readw(ahci, datal); + +#ifdef AHCI_13_STRICT + /* AHCI 1.3, Section 2.1.14 -- CAP must point to PMCAP. */ + g_assert((data & 0xFF) == PCI_CAP_ID_PM); +#elif defined Q35 + /* Intel ICH9 Family Datasheet 14.1.19 p.550 */ + if ((data & 0xFF) != PCI_CAP_ID_MSI) { + g_test_message("WARN: 1st Capability ID (%u) is not MSICAP (%u)", + data & 0xFF, PCI_CAP_ID_MSI); + } + /*g_assert((data & 0xFF) == PCI_CAP_ID_MSI);*/ +#else + if ((data & 0xFF) != PCI_CAP_ID_PM) { + g_test_message("WARN: 1st Capability ID (%u) is not PMCAP (%u)", + data & 0xFF, PCI_CAP_ID_PM); + } +#endif + + ahci_test_pci_caps(ahci, data, (uint8_t)datal); + + /* Reserved. */ + datal = qpci_config_readl(ahci, PCI_CAPABILITY_LIST + 4); + g_assert(datal == 0); + + /* IPIN might vary, but ILINE must be off. */ + datab = qpci_config_readb(ahci, PCI_INTERRUPT_LINE); + g_assert(datab == 0); +} + +/** + * Test PCI capabilities for AHCI specification adherence. + */ +static void ahci_test_pci_caps(QPCIDevice *ahci, uint16_t header, + uint8_t offset) +{ + uint8_t cid = header & 0xFF; + uint8_t next = header >> 8; + + g_test_message("CID: %02x; next: %02x", cid, next); + + switch (cid) { + case PCI_CAP_ID_PM: + ahci_test_pmcap(ahci, offset); + break; + case PCI_CAP_ID_MSI: + ahci_test_msicap(ahci, offset); + break; + case PCI_CAP_ID_SATA: + ahci_test_satacap(ahci, offset); + break; + + default: + g_test_message("Unknown CAP 0x%02x", cid); + } + + if (next) { + ahci_test_pci_caps(ahci, qpci_config_readw(ahci, next), next); + } +} + +/** + * Test SATA PCI capabilitity for AHCI specification adherence. + */ +static void ahci_test_satacap(QPCIDevice *ahci, uint8_t offset) +{ + uint16_t dataw; + uint32_t datal; + + g_test_message("Verifying SATACAP"); + + /* Assert that the SATACAP version is 1.0, And reserved bits are empty. */ + dataw = qpci_config_readw(ahci, offset + 2); + g_assert(dataw == 0x10); + + /* Grab the SATACR1 register. */ + datal = qpci_config_readw(ahci, offset + 4); + + switch (datal & 0x0F) { + case 0x04: /* BAR0 */ + case 0x05: /* BAR1 */ + case 0x06: + case 0x07: + case 0x08: + case 0x09: /* BAR5 */ + case 0x0F: /* Immediately following SATACR1 in PCI config space. */ + break; + default: + /* Invalid BARLOC for the Index Data Pair. */ + g_assert_not_reached(); + } + + /* Reserved. */ + g_assert((datal >> 24) == 0x00); +} + +/** + * Test MSI PCI capability for AHCI specification adherence. + */ +static void ahci_test_msicap(QPCIDevice *ahci, uint8_t offset) +{ + uint16_t dataw; + uint32_t datal; + + g_test_message("Verifying MSICAP"); + + dataw = qpci_config_readw(ahci, offset + PCI_MSI_FLAGS); + assert_bit_clear(dataw, PCI_MSI_FLAGS_ENABLE); + assert_bit_clear(dataw, PCI_MSI_FLAGS_QSIZE); + assert_bit_clear(dataw, PCI_MSI_FLAGS_RESERVED); + + datal = qpci_config_readl(ahci, offset + PCI_MSI_ADDRESS_LO); + g_assert(datal == 0x00); + + if (dataw & PCI_MSI_FLAGS_64BIT) { + g_test_message("MSICAP is 64bit"); + g_assert(qpci_config_readl(ahci, offset + PCI_MSI_ADDRESS_HI) == 0x00); + g_assert(qpci_config_readw(ahci, offset + PCI_MSI_DATA_64) == 0x00); + } else { + g_test_message("MSICAP is 32bit"); + g_assert(qpci_config_readw(ahci, offset + PCI_MSI_DATA_32) == 0x00); + } +} + +/** + * Test Power Management PCI capability for AHCI specification adherence. + */ +static void ahci_test_pmcap(QPCIDevice *ahci, uint8_t offset) +{ + uint16_t dataw; + + g_test_message("Verifying PMCAP"); + + dataw = qpci_config_readw(ahci, offset + PCI_PM_PMC); + assert_bit_clear(dataw, PCI_PM_CAP_PME_CLOCK); + assert_bit_clear(dataw, PCI_PM_CAP_RESERVED); + assert_bit_clear(dataw, PCI_PM_CAP_D1); + assert_bit_clear(dataw, PCI_PM_CAP_D2); + + dataw = qpci_config_readw(ahci, offset + PCI_PM_CTRL); + assert_bit_clear(dataw, PCI_PM_CTRL_STATE_MASK); + assert_bit_clear(dataw, PCI_PM_CTRL_RESERVED); + assert_bit_clear(dataw, PCI_PM_CTRL_DATA_SEL_MASK); + assert_bit_clear(dataw, PCI_PM_CTRL_DATA_SCALE_MASK); +} + /******************************************************************************/ /* Test Interfaces */ /******************************************************************************/ @@ -170,6 +428,18 @@ static void test_sanity(void) ahci_shutdown(ahci); } +/** + * Ensure that the PCI configuration space for the AHCI device is in-line with + * the AHCI 1.3 specification for initial values. + */ +static void test_pci_spec(void) +{ + QPCIDevice *ahci; + ahci_boot(&ahci); + ahci_test_pci_spec(ahci); + ahci_shutdown(ahci); +} + /******************************************************************************/ int main(int argc, char **argv) @@ -197,6 +467,7 @@ int main(int argc, char **argv) /* Run the tests */ qtest_add_func("/ahci/sanity", test_sanity); + qtest_add_func("/ahci/pci_spec", test_pci_spec); ret = g_test_run();