| Message ID | 1403650675-3368-1-git-send-email-ehabkost@redhat.com |
|---|---|
| State | New |
| Headers | show |
On Tue, Jun 24, 2014 at 07:57:55PM -0300, Eduardo Habkost wrote: > The property name is "prog_if", not "prof_if". > > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> > Cc: BALATON Zoltan <balaton@eik.bme.hu> Applied, thanks! > --- > include/hw/i386/pc.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h > index 486e98f..1331d5a 100644 > --- a/include/hw/i386/pc.h > +++ b/include/hw/i386/pc.h > @@ -358,7 +358,7 @@ bool e820_get_entry(int, uint32_t, uint64_t *, uint64_t *); > },\ > {\ > .driver = "pci-serial-2x",\ > - .property = "prof_if",\ > + .property = "prog_if",\ > .value = stringify(0),\ > },\ > {\ > -- > 1.9.3
On Tue, Jun 24, 2014 at 07:57:55PM -0300, Eduardo Habkost wrote: > The property name is "prog_if", not "prof_if". > > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> > Cc: BALATON Zoltan <balaton@eik.bme.hu> Should be reported-by, by the way. Cc: means "I have notified this person just in case". > --- > include/hw/i386/pc.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h > index 486e98f..1331d5a 100644 > --- a/include/hw/i386/pc.h > +++ b/include/hw/i386/pc.h > @@ -358,7 +358,7 @@ bool e820_get_entry(int, uint32_t, uint64_t *, uint64_t *); > },\ > {\ > .driver = "pci-serial-2x",\ > - .property = "prof_if",\ > + .property = "prog_if",\ > .value = stringify(0),\ > },\ > {\ > -- > 1.9.3
On Wed, Jun 25, 2014 at 09:00:59AM +0300, Michael S. Tsirkin wrote: > On Tue, Jun 24, 2014 at 07:57:55PM -0300, Eduardo Habkost wrote: > > The property name is "prog_if", not "prof_if". > > > > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> > > Cc: BALATON Zoltan <balaton@eik.bme.hu> > > Should be reported-by, by the way. > Cc: means "I have notified this person just in case". Fixed up on my branch no need to repost. > > --- > > include/hw/i386/pc.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h > > index 486e98f..1331d5a 100644 > > --- a/include/hw/i386/pc.h > > +++ b/include/hw/i386/pc.h > > @@ -358,7 +358,7 @@ bool e820_get_entry(int, uint32_t, uint64_t *, uint64_t *); > > },\ > > {\ > > .driver = "pci-serial-2x",\ > > - .property = "prof_if",\ > > + .property = "prog_if",\ > > .value = stringify(0),\ > > },\ > > {\ > > -- > > 1.9.3
diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h index 486e98f..1331d5a 100644 --- a/include/hw/i386/pc.h +++ b/include/hw/i386/pc.h @@ -358,7 +358,7 @@ bool e820_get_entry(int, uint32_t, uint64_t *, uint64_t *); },\ {\ .driver = "pci-serial-2x",\ - .property = "prof_if",\ + .property = "prog_if",\ .value = stringify(0),\ },\ {\
The property name is "prog_if", not "prof_if". Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> Cc: BALATON Zoltan <balaton@eik.bme.hu> --- include/hw/i386/pc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)