From patchwork Wed May 28 13:21:40 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Gonglei (Arei)" X-Patchwork-Id: 353432 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id AEC1B1400A8 for ; Wed, 28 May 2014 23:22:43 +1000 (EST) Received: from localhost ([::1]:42063 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WpdoX-0006oS-C0 for incoming@patchwork.ozlabs.org; Wed, 28 May 2014 09:22:41 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55981) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wpdo9-0006Hz-3r for qemu-devel@nongnu.org; Wed, 28 May 2014 09:22:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wpdo1-0007Ty-PB for qemu-devel@nongnu.org; Wed, 28 May 2014 09:22:17 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:29077) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wpdo1-0007Sv-5F for qemu-devel@nongnu.org; Wed, 28 May 2014 09:22:09 -0400 Received: from 172.24.2.119 (EHLO szxeml205-edg.china.huawei.com) ([172.24.2.119]) by szxrg03-dlp.huawei.com (MOS 4.4.3-GA FastPath queued) with ESMTP id APG47236; Wed, 28 May 2014 21:22:04 +0800 (CST) Received: from SZXEML421-HUB.china.huawei.com (10.82.67.160) by szxeml205-edg.china.huawei.com (172.24.2.58) with Microsoft SMTP Server (TLS) id 14.3.158.1; Wed, 28 May 2014 21:22:03 +0800 Received: from localhost (10.177.19.102) by szxeml421-hub.china.huawei.com (10.82.67.160) with Microsoft SMTP Server id 14.3.158.1; Wed, 28 May 2014 21:21:55 +0800 From: To: Date: Wed, 28 May 2014 21:21:40 +0800 Message-ID: <1401283300-14176-7-git-send-email-arei.gonglei@huawei.com> X-Mailer: git-send-email 1.7.3.1.msysgit.0 In-Reply-To: <1401283300-14176-1-git-send-email-arei.gonglei@huawei.com> References: <1401283300-14176-1-git-send-email-arei.gonglei@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.177.19.102] X-CFilter-Loop: Reflected X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 119.145.14.66 Cc: kwolf@redhat.com, peter.crosthwaite@xilinx.com, weidong.huang@huawei.com, aliguori@amazon.com, mst@redhat.com, luonengjun@huawei.com, armbru@redhat.com, lcapitulino@redhat.com, qiaonuohan@cn.fujitsu.com, Gonglei , av1474@comtv.ru, kraxel@redhat.com, stefanha@redhat.com, crobinso@redhat.com, pbonzini@redhat.com, lersek@redhat.com, afaerber@suse.de Subject: [Qemu-devel] [PATCH v2 6/6] audio: Fix using freed pointer in wav_fini_out() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Gonglei Spotted by Coverity: (8) Event freed_arg: "fclose(FILE *)" frees "wav->f". (9) Event cond_true: Condition "fclose(wav->f)", taking true branch Also see events: [pass_freed_arg] 212 if (fclose (wav->f)) { (10) Event pass_freed_arg: Passing freed pointer "wav->f" as an argument to function "AUD_log(char const *, char const *, ...)". Also see events: [freed_arg] 213 dolog ("wav_fini_out: fclose %p failed\nReason: %s\n", 214 wav->f, strerror (errno)); Removed wav->f's pointer in error log, actually it's uselessly. Signed-off-by: Gonglei Reviewed-by: Paolo Bonzini Reviewed-by: Stefan Hajnoczi --- audio/wavaudio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/audio/wavaudio.c b/audio/wavaudio.c index 6846a1a..9bbe8e9 100644 --- a/audio/wavaudio.c +++ b/audio/wavaudio.c @@ -210,8 +210,8 @@ static void wav_fini_out (HWVoiceOut *hw) doclose: if (fclose (wav->f)) { - dolog ("wav_fini_out: fclose %p failed\nReason: %s\n", - wav->f, strerror (errno)); + dolog ("wav_fini_out: fclose 'wav->f' failed\nReason: %s\n", + strerror (errno)); } wav->f = NULL;