From patchwork Tue May 20 18:14:39 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 350815 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id A363214008B for ; Wed, 21 May 2014 04:15:44 +1000 (EST) Received: from localhost ([::1]:54884 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmoZh-00016O-It for incoming@patchwork.ozlabs.org; Tue, 20 May 2014 14:15:41 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43803) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmoZ1-0008Gx-EK for qemu-devel@nongnu.org; Tue, 20 May 2014 14:15:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WmoYs-0005Vp-ET for qemu-devel@nongnu.org; Tue, 20 May 2014 14:14:59 -0400 Received: from mail-ee0-x22f.google.com ([2a00:1450:4013:c00::22f]:54906) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmoYs-0005Vb-7P for qemu-devel@nongnu.org; Tue, 20 May 2014 14:14:50 -0400 Received: by mail-ee0-f47.google.com with SMTP id c13so857987eek.34 for ; Tue, 20 May 2014 11:14:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=oWjlQ56LglSe1EpQvsn8N1J2Oq7uqHG4Z6eKu126w9g=; b=o9WzgnUigWsSahGI7Q7qewh7kRtIJEqXDIjBuAhvZDXJnIewv9MZGPxEkei36B24Pq fi6f8tJKNzgoo0FHK8oWA/4Xd/d5+fM+OGwiAS4/6VnkyruwrQEA2wHNdJjOYHvFg0U4 1s3dFG5lcVWXDoLa3alhXD3XPb6sdWVSMZakfV5pJUKqCWgK2/ZTpK1CPIrDWQ1xxd7K eNNod2jy9GrYh1BSYi/37VNe5CMO9W63jC3LxBvppLMOgkYR/k8/BlReX+hUyB2B5mhf 9SY54kHvCn82D+PluNABKTDOKzditwEXTCmO9vPt/LfnN55rlS4Sf/kZZmwTociIpzJa +SEQ== X-Received: by 10.15.33.140 with SMTP id c12mr6385652eev.41.1400609689473; Tue, 20 May 2014 11:14:49 -0700 (PDT) Received: from playground.station (net-37-117-141-58.cust.vodafonedsl.it. [37.117.141.58]) by mx.google.com with ESMTPSA id b1sm5605594eef.15.2014.05.20.11.14.47 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 May 2014 11:14:48 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 20 May 2014 20:14:39 +0200 Message-Id: <1400609682-22166-2-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1400609682-22166-1-git-send-email-pbonzini@redhat.com> References: <1400609682-22166-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c00::22f Cc: Markus Armbruster Subject: [Qemu-devel] [PULL 1/4] scsi: Document intentional fall through in scsi_req_length() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Markus Armbruster For clarity, and to hush up Coverity. Signed-off-by: Markus Armbruster Signed-off-by: Paolo Bonzini --- hw/scsi/scsi-bus.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c index ae921a6..26770fb 100644 --- a/hw/scsi/scsi-bus.c +++ b/hw/scsi/scsi-bus.c @@ -938,6 +938,7 @@ static int scsi_req_length(SCSICommand *cmd, SCSIDevice *dev, uint8_t *buf) if (cmd->xfer == 0) { cmd->xfer = 256; } + /* fall through */ case WRITE_10: case WRITE_VERIFY_10: case WRITE_12: @@ -952,6 +953,7 @@ static int scsi_req_length(SCSICommand *cmd, SCSIDevice *dev, uint8_t *buf) if (cmd->xfer == 0) { cmd->xfer = 256; } + /* fall through */ case READ_10: case RECOVER_BUFFERED_DATA: case READ_12: