diff mbox

readline: use g_strndup instead of open-coding it

Message ID 1399281906-479-1-git-send-email-mjt@msgid.tls.msk.ru
State New
Headers show

Commit Message

Michael Tokarev May 5, 2014, 9:25 a.m. UTC 
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 util/readline.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Andreas Färber May 5, 2014, 9:39 a.m. UTC | #1 
Am 05.05.2014 11:25, schrieb Michael Tokarev:
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
>  util/readline.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/util/readline.c b/util/readline.c
> index 8441be4..a3fd2cb 100644
> --- a/util/readline.c
> +++ b/util/readline.c
> @@ -279,9 +279,7 @@ static void readline_completion(ReadLineState *rs)
>  
>      rs->nb_completions = 0;
>  
> -    cmdline = g_malloc(rs->cmd_buf_index + 1);
> -    memcpy(cmdline, rs->cmd_buf, rs->cmd_buf_index);
> -    cmdline[rs->cmd_buf_index] = '\0';
> +    cmdline = g_strndup(rs->cmd_buf, rs->cmd_buf_index);
>      rs->completion_finder(rs->opaque, cmdline);
>      g_free(cmdline);
>  

Reviewed-by: Andreas Färber <afaerber@suse.de>

Andreas
diff mbox

Patch

diff --git a/util/readline.c b/util/readline.c
index 8441be4..a3fd2cb 100644
--- a/util/readline.c
+++ b/util/readline.c
@@ -279,9 +279,7 @@  static void readline_completion(ReadLineState *rs)
 
     rs->nb_completions = 0;
 
-    cmdline = g_malloc(rs->cmd_buf_index + 1);
-    memcpy(cmdline, rs->cmd_buf, rs->cmd_buf_index);
-    cmdline[rs->cmd_buf_index] = '\0';
+    cmdline = g_strndup(rs->cmd_buf, rs->cmd_buf_index);
     rs->completion_finder(rs->opaque, cmdline);
     g_free(cmdline);